[Merged by Bors] - atxs: regossip atxs in publish epoch #5097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dshulyak
requested review from
countvonzero,
fasmat and
poszu
as code owners
Codecov Report
@@ Coverage Diff @@
## develop #5097 +/- ##
=========================================
- Coverage 77.0% 77.0% -0.1%
=========================================
Files 257 257
Lines 30278 30320 +42
=========================================
+ Hits 23339 23368 +29
- Misses 5410 5420 +10
- Partials 1529 1532 +3
|
fasmat
reviewed
Sep 27, 2023
poszu
approved these changes
Sep 27, 2023
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Sep 27, 2023
closes: #5068 there is an indication that not all atxs are propagated before target epoch starts. it results in efficiency in some data structures and in future will lead to lost rewards. if node was offline when built an atx or experienced some other problems, the only chance it has to broadcast an atx is when peers asks for it (atx sync). that approach is in general not scalable and naive about concurrent requests. as atx are not large (~1KB) we can regossip them periodically. if peer already stores this atx it will not gossip it futher
dshulyak
force-pushed
the
regossip-atxs-periodically
branch
from
4a661fc
to
e5bef32
Compare
|
Canceled. |
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Sep 27, 2023
closes: #5068 there is an indication that not all atxs are propagated before target epoch starts. it results in efficiency in some data structures and in future will lead to lost rewards. if node was offline when built an atx or experienced some other problems, the only chance it has to broadcast an atx is when peers asks for it (atx sync). that approach is in general not scalable and naive about concurrent requests. as atx are not large (~1KB) we can regossip them periodically. if peer already stores this atx it will not gossip it futher
|
Pull request successfully merged into develop. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #5068
there is an indication that not all atxs are propagated before target epoch starts. it results in efficiency in some data structures and in future will lead to lost rewards.
if node was offline when built an atx or experienced some other problems, the only chance it has to broadcast an atx is when peers asks for it (atx sync). that approach is in general not scalable and naive about concurrent requests.
as atx are not large (~1KB) we can regossip them periodically. if peer already stores this atx it will not gossip it futher