[Merged by Bors] - Fix "log.SetLogger(...) was never called" warning #5095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fasmat
force-pushed
the
fix-systest-complaints
branch
from
d301720
to
2cc9cce
Compare
Codecov Report
@@ Coverage Diff @@
## develop #5095 +/- ##
=======================================
Coverage 77.0% 77.0%
=======================================
Files 257 257
Lines 30278 30278
=======================================
+ Hits 23328 23344 +16
+ Misses 5423 5407 -16
Partials 1527 1527 |
fasmat
force-pushed
the
fix-systest-complaints
branch
from
dc22780
to
0f4531a
Compare
poszu
approved these changes
Sep 27, 2023
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Sep 27, 2023
## Motivation
System tests sometimes complain with a warning about this issue:
```
[controller-runtime] log.SetLogger(...) was never called; logs will not be displayed.
Detected at:
> goroutine 89 [running]:
> runtime/debug.Stack()
> /usr/local/go/src/runtime/debug/stack.go:24 +0x5e
> sigs.k8s.io/controller-runtime/pkg/log.eventuallyFulfillRoot()
> /go/pkg/mod/sigs.k8s.io/controller-runtime@v0.16.2/pkg/log/log.go:60 +0xcd
> sigs.k8s.io/controller-runtime/pkg/log.(*delegatingLogSink).WithName(0xc0001f3400, {0x1d7b101, 0x14})
> /go/pkg/mod/sigs.k8s.io/controller-runtime@v0.16.2/pkg/log/deleg.go:147 +0x45
> github.com/go-logr/logr.Logger.WithName({{0x201aac0, 0xc0001f3400}, 0x0}, {0x1d7b101?, 0x1d63709?})
> /go/pkg/mod/github.com/go-logr/logr@v1.2.4/logr.go:336 +0x3d
> sigs.k8s.io/controller-runtime/pkg/client.newClient(0x1d09720?, {0x0, 0xc003dfa3f0, {0x0, 0x0}, 0x0, {0x0, 0x0}, 0x0})
> /go/pkg/mod/sigs.k8s.io/controller-runtime@v0.16.2/pkg/client/client.go:122 +0xec
> sigs.k8s.io/controller-runtime/pkg/client.New(0x20024e0?, {0x0, 0xc003dfa3f0, {0x0, 0x0}, 0x0, {0x0, 0x0}, 0x0})
> /go/pkg/mod/sigs.k8s.io/controller-runtime@v0.16.2/pkg/client/client.go:103 +0x7d
> github.com/spacemeshos/go-spacemesh/systest/testcontext.New(0xc000187380, {0xc0003c5f18, 0x1, 0x5ac?})
> /build/systest/testcontext/context.go:291 +0x32e
> github.com/spacemeshos/go-spacemesh/systest/tests.TestPartition_30_70(0xc0001031e0?)
> /build/systest/tests/partition_test.go:174 +0xc8
> testing.tRunner(0xc000187380, 0x1e6c4c0)
> /usr/local/go/src/testing/testing.go:1595 +0xff
> created by testing.(*T).Run in goroutine 1
> /usr/local/go/src/testing/testing.go:1648 +0x3ad
```
This PR tries to fix that warning
## Changes
- set a logger for controller-runtime in system tests
## Test Plan
n/a
## TODO
<!-- This section should be removed when all items are complete -->
- [x] Explain motivation or link existing issue(s)
- [x] Test changes and document test plan
- [x] Update documentation as needed
- [x] Update [changelog](../CHANGELOG.md) as needed
|
Pull request successfully merged into develop. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page.
|
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
System tests sometimes complain with a warning about this issue:
This PR tries to fix that warning
Changes
Test Plan
n/a
TODO