[Merged by Bors] - don't track latency for messages that are not gossipped futher #5064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is mainly to prevennt duplicates from skewing results
dshulyak
requested review from
countvonzero,
fasmat and
poszu
as code owners
poszu
reviewed
Sep 22, 2023
poszu
approved these changes
Sep 28, 2023
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Sep 28, 2023
this is mainly to prevent duplicates from skewing results. hare1 is not fixed in this change latency metering is dropped for atx protocol, as we don't have good reference for it closes: #4623
|
Build failed: |
dshulyak
force-pushed
the
proper-latency
branch
from
5fcb1aa
to
379cda1
Compare
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Sep 28, 2023
this is mainly to prevent duplicates from skewing results. hare1 is not fixed in this change latency metering is dropped for atx protocol, as we don't have good reference for it closes: #4623
|
Build failed: |
|
bors cancel |
dshulyak
force-pushed
the
proper-latency
branch
from
9a54227
to
609f26c
Compare
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Sep 28, 2023
this is mainly to prevent duplicates from skewing results. hare1 is not fixed in this change latency metering is dropped for atx protocol, as we don't have good reference for it closes: #4623
Codecov Report
@@ Coverage Diff @@
## develop #5064 +/- ##
=========================================
- Coverage 77.1% 77.1% -0.1%
=========================================
Files 257 257
Lines 30307 30287 -20
=========================================
- Hits 23371 23354 -17
+ Misses 5411 5408 -3
Partials 1525 1525
|
|
Pull request successfully merged into develop. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is mainly to prevent duplicates from skewing results.
hare1 is not fixed in this change
latency metering is dropped for atx protocol, as we don't have good reference for it
closes: #4623