Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - proposal signed data was used in id #4992

Closed
wants to merge 5 commits into from

Conversation

dshulyak
Copy link
Contributor

@dshulyak dshulyak commented Sep 8, 2023

{"L":"ERROR","T":"2023-09-08T15:46:18.944Z","N":"9aa91.blockGenerator","M":"failed to process hare output","node_id":"9aa91374168177589adb11c04a9984f33684e3e3cee72b4298c4d5d56d03dcdb","module":"blockGenerator","layer_id":12,"errmsg":"preprocess fetch layer 12 proposals: hint: proposalDB, hash: 0x1d286d884f4a8699182bde631972d1ad649549aa000000000000000000000000, err: validation reject: incorrect hash: proposal want 1d286d884f, got c2986cf657\nhint: proposalDB, hash: 0xab3ef72044915bb64ef3c7eacfdd98f923a72195000000000000000000000000, err: validation reject: incorrect hash: proposal want ab3ef72044, got 9eafb3985e\nhint: proposalDB, hash: 0x5a0cbb754637b44d5df63ca6938be1fad001ac4b000000000000000000000000, err: validation reject: incorrect hash: proposal want 5a0cbb7546, got ab4994459c","name":"blockGenerator"}

@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Merging #4992 (d675c4d) into develop (0cb8203) will decrease coverage by 0.1%.
The diff coverage is 100.0%.

❗ Current head d675c4d differs from pull request most recent head dcd8f01. Consider uploading reports for the commit dcd8f01 to get more accurate results

@@            Coverage Diff            @@
##           develop   #4992     +/-   ##
=========================================
- Coverage     77.1%   77.1%   -0.1%     
=========================================
  Files          254     254             
  Lines        30281   30282      +1     
=========================================
- Hits         23361   23357      -4     
- Misses        5401    5410      +9     
+ Partials      1519    1515      -4     
Files Changed Coverage Δ
proposals/handler.go 87.0% <100.0%> (+0.7%) ⬆️

... and 4 files with indirect coverage changes

@dshulyak dshulyak marked this pull request as ready for review September 11, 2023 06:20
@dshulyak
Copy link
Contributor Author

bors try

bors bot added a commit that referenced this pull request Sep 11, 2023
@bors
Copy link

bors bot commented Sep 11, 2023

try

Build failed:

proposals/handler.go Outdated Show resolved Hide resolved
@dshulyak
Copy link
Contributor Author

bors try

bors bot added a commit that referenced this pull request Sep 11, 2023
Co-authored-by: Bartosz Różański <bartek.roza@gmail.com>
@bors
Copy link

bors bot commented Sep 11, 2023

try

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@dshulyak
Copy link
Contributor Author

bors merge

bors bot pushed a commit that referenced this pull request Sep 11, 2023
> {"L":"ERROR","T":"2023-09-08T15:46:18.944Z","N":"9aa91.blockGenerator","M":"failed to process hare output","node_id":"9aa91374168177589adb11c04a9984f33684e3e3cee72b4298c4d5d56d03dcdb","module":"blockGenerator","layer_id":12,"errmsg":"preprocess fetch layer 12 proposals: hint: proposalDB, hash: 0x1d286d884f4a8699182bde631972d1ad649549aa000000000000000000000000, err: validation reject: incorrect hash: proposal want 1d286d884f, got c2986cf657\nhint: proposalDB, hash: 0xab3ef72044915bb64ef3c7eacfdd98f923a72195000000000000000000000000, err: validation reject: incorrect hash: proposal want ab3ef72044, got 9eafb3985e\nhint: proposalDB, hash: 0x5a0cbb754637b44d5df63ca6938be1fad001ac4b000000000000000000000000, err: validation reject: incorrect hash: proposal want 5a0cbb7546, got ab4994459c","name":"blockGenerator"}
@bors
Copy link

bors bot commented Sep 11, 2023

Pull request successfully merged into develop.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title proposal signed data was used in id [Merged by Bors] - proposal signed data was used in id Sep 11, 2023
@bors bors bot closed this Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants