Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Update spacemesh dependencies #4991

Closed
wants to merge 1 commit into from

Conversation

fasmat
Copy link
Member

@fasmat fasmat commented Sep 8, 2023

Motivation

Dependabot seems to struggle at the moment. It hasn't created PRs for these packages within 24 hours (which it normally does) and it fails to rebase some existing PRs. I created this PR to update our own dependencies.

All of these have been updated for Go 1.20, without functional changes.

Changes

  • Update github.com/spacemeshos/go-scale
  • Update github.com/spacemeshos/fixed
  • Update github.com/spacemeshos/api/release/go

Test Plan

TODO

  • Explain motivation or link existing issue(s)
  • Test changes and document test plan
  • Update documentation as needed
  • Update changelog as needed

@fasmat fasmat self-assigned this Sep 8, 2023
@fasmat fasmat requested a review from poszu as a code owner September 8, 2023 13:43
@fasmat fasmat force-pushed the update-spacemesh-dependencies branch from 2f24bab to 1404404 Compare September 8, 2023 13:46
@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Merging #4991 (1404404) into develop (3092724) will decrease coverage by 0.1%.
Report is 1 commits behind head on develop.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           develop   #4991     +/-   ##
=========================================
- Coverage     77.1%   77.1%   -0.1%     
=========================================
  Files          254     254             
  Lines        30253   30253             
=========================================
- Hits         23338   23336      -2     
- Misses        5400    5402      +2     
  Partials      1515    1515             

see 1 file with indirect coverage changes

📢 Have feedback on the report? Share it here.

@fasmat
Copy link
Member Author

fasmat commented Sep 8, 2023

bors merge

bors bot pushed a commit that referenced this pull request Sep 8, 2023
## Motivation
Dependabot seems to struggle at the moment. It hasn't created PRs for these packages within 24 hours (which it normally does) and it fails to rebase some existing PRs. I created this PR to update our own dependencies.

All of these have been updated for Go 1.20, without functional changes.

## Changes
- Update `github.com/spacemeshos/go-scale`
- Update `github.com/spacemeshos/fixed`
- Update `github.com/spacemeshos/api/release/go`

## Test Plan
<!-- Please specify how these changes were tested
(e.g. unit tests, manual testing, etc.) -->

## TODO
<!-- This section should be removed when all items are complete -->
- [x] Explain motivation or link existing issue(s)
- [x] Test changes and document test plan
- [x] Update documentation as needed
- [ ] Update [changelog](../CHANGELOG.md) as needed
@bors
Copy link

bors bot commented Sep 8, 2023

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Sep 8, 2023
## Motivation
Dependabot seems to struggle at the moment. It hasn't created PRs for these packages within 24 hours (which it normally does) and it fails to rebase some existing PRs. I created this PR to update our own dependencies.

All of these have been updated for Go 1.20, without functional changes.

## Changes
- Update `github.com/spacemeshos/go-scale`
- Update `github.com/spacemeshos/fixed`
- Update `github.com/spacemeshos/api/release/go`

## Test Plan
<!-- Please specify how these changes were tested
(e.g. unit tests, manual testing, etc.) -->

## TODO
<!-- This section should be removed when all items are complete -->
- [x] Explain motivation or link existing issue(s)
- [x] Test changes and document test plan
- [x] Update documentation as needed
- [ ] Update [changelog](../CHANGELOG.md) as needed
@bors
Copy link

bors bot commented Sep 8, 2023

Pull request successfully merged into develop.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title Update spacemesh dependencies [Merged by Bors] - Update spacemesh dependencies Sep 8, 2023
@bors bors bot closed this Sep 8, 2023
@bors bors bot deleted the update-spacemesh-dependencies branch September 8, 2023 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants