New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - fix regression in proposals sync #4986
Conversation
bors try |
Codecov Report
@@ Coverage Diff @@
## develop #4986 +/- ##
=========================================
- Coverage 77.1% 77.1% -0.1%
=========================================
Files 254 254
Lines 30253 30260 +7
=========================================
+ Hits 23345 23349 +4
- Misses 5394 5397 +3
Partials 1514 1514
... and 2 files with indirect coverage changes 📢 Have feedback on the report? Share it here. |
346872c
to
dae720a
Compare
tryBuild succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
bors merge |
on sync path activeset is downloaded together with proposals so that not updated nodes can download data. however starting at specific layer (in systests in all layers) we only sign empty activeset, so after downloading proposals it should not pass this validation.
Build failed: |
bors merge |
on sync path activeset is downloaded together with proposals so that not updated nodes can download data. however starting at specific layer (in systests in all layers) we only sign empty activeset, so after downloading proposals it should not pass this validation.
Pull request successfully merged into develop. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
on sync path activeset is downloaded together with proposals so that not updated nodes can download data.
however starting at specific layer (in systests in all layers) we only sign empty activeset, so after downloading proposals it should not pass this validation.