Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - fix regression in proposals sync #4986

Closed
wants to merge 4 commits into from

Conversation

dshulyak
Copy link
Contributor

@dshulyak dshulyak commented Sep 8, 2023

on sync path activeset is downloaded together with proposals so that not updated nodes can download data.
however starting at specific layer (in systests in all layers) we only sign empty activeset, so after downloading proposals it should not pass this validation.

@dshulyak
Copy link
Contributor Author

dshulyak commented Sep 8, 2023

bors try

@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Merging #4986 (14a6962) into develop (2cb15f9) will decrease coverage by 0.1%.
Report is 1 commits behind head on develop.
The diff coverage is 88.8%.

@@            Coverage Diff            @@
##           develop   #4986     +/-   ##
=========================================
- Coverage     77.1%   77.1%   -0.1%     
=========================================
  Files          254     254             
  Lines        30253   30260      +7     
=========================================
+ Hits         23345   23349      +4     
- Misses        5394    5397      +3     
  Partials      1514    1514             
Files Changed Coverage Δ
proposals/handler.go 86.2% <88.8%> (+0.2%) ⬆️

... and 2 files with indirect coverage changes

📢 Have feedback on the report? Share it here.

bors bot added a commit that referenced this pull request Sep 8, 2023
@bors
Copy link

bors bot commented Sep 8, 2023

try

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@dshulyak
Copy link
Contributor Author

dshulyak commented Sep 8, 2023

bors merge

bors bot pushed a commit that referenced this pull request Sep 8, 2023
on sync path activeset is downloaded together with proposals so that not updated nodes can download data.
however starting at specific layer (in systests in all layers) we only sign empty activeset, so after downloading proposals it should not pass this validation.
@bors
Copy link

bors bot commented Sep 8, 2023

Build failed:

@dshulyak
Copy link
Contributor Author

dshulyak commented Sep 8, 2023

bors merge

bors bot pushed a commit that referenced this pull request Sep 8, 2023
on sync path activeset is downloaded together with proposals so that not updated nodes can download data.
however starting at specific layer (in systests in all layers) we only sign empty activeset, so after downloading proposals it should not pass this validation.
@bors
Copy link

bors bot commented Sep 8, 2023

Pull request successfully merged into develop.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title fix regression in proposals sync [Merged by Bors] - fix regression in proposals sync Sep 8, 2023
@bors bors bot closed this Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants