[Merged by Bors] - tortoise: load ref ballots before other #4944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this can be seen as attack, where ref ballots is published, everyone is using that as base ballot, and then ref ballot gets cancelled. we still need to load it in state, otherwise it may block counting honest ballots
dshulyak
requested review from
countvonzero,
fasmat and
poszu
as code owners
Codecov Report
@@ Coverage Diff @@
## develop #4944 +/- ##
=======================================
Coverage 77.1% 77.1%
=======================================
Files 263 263
Lines 30532 30537 +5
=======================================
+ Hits 23558 23563 +5
Misses 5486 5486
Partials 1488 1488
|
countvonzero
approved these changes
Sep 1, 2023
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Sep 1, 2023
this can be seen as attack, where ref ballots is published, everyone is using that as base ballot, and then ref ballot gets cancelled. we still need to load it in state, otherwise it may block counting honest ballots
|
Pull request successfully merged into develop. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this can be seen as attack, where ref ballots is published, everyone is using that as base ballot,
and then ref ballot gets cancelled.
we still need to load it in state, otherwise it may block counting honest ballots