Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - hare/oracle: reset oracle when node enters synced state #4936

Closed

Conversation

dshulyak
Copy link
Contributor

@dshulyak dshulyak commented Aug 31, 2023

closes: #4552

the none invasive solution to mitigate problem with loading wrong activeset during sync, until we switch to graded oracle

@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Merging #4936 (e551515) into develop (5d25947) will decrease coverage by 0.1%.
Report is 2 commits behind head on develop.
The diff coverage is 86.3%.

@@            Coverage Diff            @@
##           develop   #4936     +/-   ##
=========================================
- Coverage     77.1%   77.1%   -0.1%     
=========================================
  Files          263     263             
  Lines        30532   30550     +18     
=========================================
+ Hits         23558   23567      +9     
- Misses        5486    5492      +6     
- Partials      1488    1491      +3     
Files Changed Coverage Δ
hare/eligibility/oracle.go 75.0% <85.7%> (+0.4%) ⬆️
node/node.go 63.0% <100.0%> (+<0.1%) ⬆️

... and 6 files with indirect coverage changes

@dshulyak
Copy link
Contributor Author

dshulyak commented Sep 1, 2023

bors merge

bors bot pushed a commit that referenced this pull request Sep 1, 2023
closes: #4552

the none invasive solution to mitigate problem with loading wrong activeset during sync, until we switch to graded oracle
@bors
Copy link

bors bot commented Sep 1, 2023

Pull request successfully merged into develop.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title hare/oracle: reset oracle when node enters synced state [Merged by Bors] - hare/oracle: reset oracle when node enters synced state Sep 1, 2023
@bors bors bot closed this Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hare loads incorrect (tortoise) active set during sync
2 participants