Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Prepare v1.1.2 release #4898

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - Prepare v1.1.2 release #4898

wants to merge 2 commits into from

Conversation

fasmat
Copy link
Member

@fasmat fasmat commented Aug 23, 2023 •
edited

Motivation

Prepares a new release: v1.1.2

Changes

  • Update RELEASE.md
  • After merge: rebase v1.1 branch and tag v1.1.2

Test Plan

n/a

TODO

  • Explain motivation or link existing issue(s)
  • Test changes and document test plan
  • Update documentation as needed

DevOps Notes

  • This PR does not require configuration changes (e.g., environment variables, GitHub secrets, VM resources)
  • This PR does not affect public APIs
  • This PR does not rely on a new version of external services (PoET, elasticsearch, etc.)
  • This PR does not make changes to log messages (which monitoring infrastructure may rely on)

@fasmat fasmat self-assigned this Aug 23, 2023
@fasmat fasmat requested review from pigmej and piersy August 23, 2023 18:56
@codecov
Copy link

codecov bot commented Aug 23, 2023 •
edited

Codecov Report

Merging #4898 (1b5a594) into develop (8d3bdc4) will increase coverage by 0.0%.
Report is 1 commits behind head on develop.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           develop   #4898   +/-   ##
=======================================
  Coverage     76.7%   76.8%           
=======================================
  Files          256     256           
  Lines        29635   29635           
=======================================
+ Hits         22757   22761    +4     
+ Misses        5411    5403    -8     
- Partials      1467    1471    +4

see 6 files with indirect coverage changes

piersy
piersy approved these changes Aug 23, 2023
View reviewed changes
Copy link
Contributor

@piersy piersy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

dshulyak
dshulyak reviewed Aug 24, 2023
View reviewed changes
CHANGELOG.md
@@ -2,7 +2,7 @@

See [RELEASE](./RELEASE.md) for workflow instructions.

## UNRELEASED
## v1.1.2
Copy link
Contributor

@dshulyak dshulyak Aug 24, 2023 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i thought that we may want to put a placeholder for UNRELEASED when cutting a release, but it is cleaner to add UNRELEASED section with first change. maybe will store placeholder in RELEASE.md so that it can be copied easily

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also thought we add the UNRELEASED section back in with the first change. I'll add a template to the RELEASE.md document

@fasmat fasmat requested a review from dshulyak August 24, 2023 07:47
@fasmat
Copy link
Member Author

fasmat commented Aug 24, 2023

bors merge

bors bot pushed a commit that referenced this pull request Aug 24, 2023
@fasmat
Prepare v1.1.2 release (#4898)
1132af2 
## Motivation
Prepares a new release: v1.1.2

## Changes
- Update RELEASE.md
- After merge: rebase `v1.1` branch and tag `v1.1.2`

## Test Plan
n/a

## TODO
<!-- This section should be removed when all items are complete -->
- [x] Explain motivation or link existing issue(s)
- [x] Test changes and document test plan
- [x] Update documentation as needed

## DevOps Notes
<!-- Please uncheck these items as applicable to make DevOps aware of changes that may affect releases -->
- [x] This PR does not require configuration changes (e.g., environment variables, GitHub secrets, VM resources)
- [x] This PR does not affect public APIs
- [x] This PR does not rely on a new version of external services (PoET, elasticsearch, etc.)
- [x] This PR does not make changes to log messages (which monitoring infrastructure may rely on)
@bors
Copy link

bors bot commented Aug 24, 2023

Pull request successfully merged into develop.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title Prepare v1.1.2 release [Merged by Bors] - Prepare v1.1.2 release Aug 24, 2023
@bors bors bot closed this Aug 24, 2023
@bors bors bot deleted the prepare-1.1.2-release branch August 24, 2023 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piersy piersy piersy approved these changes

@countvonzero countvonzero Awaiting requested review from countvonzero

@poszu poszu Awaiting requested review from poszu poszu is a code owner

@pigmej pigmej Awaiting requested review from pigmej

@dshulyak dshulyak Awaiting requested review from dshulyak dshulyak is a code owner

Assignees

@fasmat fasmat

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fasmat @dshulyak @piersy