[Merged by Bors] - Fixes failing TestPeerInfoApi test on windows #4888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piersy
requested review from
countvonzero,
dshulyak,
fasmat and
poszu
as code owners
Codecov Report
@@ Coverage Diff @@
## develop #4888 +/- ##
=========================================
- Coverage 76.9% 76.8% -0.1%
=========================================
Files 261 261
Lines 30259 30259
=========================================
- Hits 23274 23265 -9
- Misses 5485 5493 +8
- Partials 1500 1501 +1 |
fasmat
approved these changes
Aug 21, 2023
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Aug 22, 2023
## Motivation This fixes the `TestPeerInfoApi` test currently failing on our windows CI run. ## Changes Moved the call to `t.Cleanup` to close apps to be after any call to `t.TempDir` used to setup apps, this ensures that we first close apps, and then delete their temp dirs as opposed to vice-versa. ## Test Plan See that `TestPeerInfoApi` passes on the windows CI run.
|
Pull request successfully merged into develop. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This fixes the
TestPeerInfoApitest currently failing on our windows CI run.Changes
Moved the call to
t.Cleanupto close apps to be after any call tot.TempDirused to setup apps, this ensures that we first close apps, and then delete their temp dirs as opposed to vice-versa.Test Plan
See that
TestPeerInfoApipasses on the windows CI run.