Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - miner oracle use ref ballot for active set #4876

Closed
wants to merge 3 commits into from
Closed

[Merged by Bors] - miner oracle use ref ballot for active set #4876

wants to merge 3 commits into from

Conversation

countvonzero
Copy link
Contributor

Motivation

Closes #4837
Closes #4838

Changes

  • use active set from ref ballot when available
  • new criteria to decide if a node should use epoch's first block to derive active set:
    90% of its epoch active set do not have acceptable grade

@codecov
Copy link

codecov bot commented Aug 19, 2023 •
edited

Codecov Report

Merging #4876 (4bdad34) into develop (b9f3333) will decrease coverage by 0.1%.
Report is 1 commits behind head on develop.
The diff coverage is 76.6%.

@@            Coverage Diff            @@
##           develop   #4876     +/-   ##
=========================================
- Coverage     76.8%   76.8%   -0.1%     
=========================================
  Files          261     261             
  Lines        30095   30160     +65     
=========================================
+ Hits         23133   23174     +41     
- Misses        5472    5489     +17     
- Partials      1490    1497      +7
Files Changed Coverage Δ
config/config.go 100.0% <ø> (ø)
syncer/syncer.go 94.1% <ø> (+0.5%) ⬆️
system/mocks/sync.go 100.0% <ø> (ø)
node/node.go 64.9% <33.3%> (-0.2%) ⬇️
miner/oracle.go 72.5% <77.8%> (+0.8%) ⬆️
config/presets/fastnet.go 100.0% <100.0%> (ø)
miner/proposal_builder.go 84.2% <100.0%> (+0.2%) ⬆️

... and 5 files with indirect coverage changes

@countvonzero
Copy link
Contributor Author

bors try

bors bot added a commit that referenced this pull request Aug 19, 2023
@bors
Try #4876:
fbeafbd
@bors
Copy link

bors bot commented Aug 19, 2023

try

Build failed:

@countvonzero
Copy link
Contributor Author

bors merge

bors bot pushed a commit that referenced this pull request Aug 20, 2023
@countvonzero
miner oracle use ref ballot for active set (#4876)
be8fe05 
## Motivation
Closes #4837
Closes #4838

## Changes
- use active set from ref ballot when available
- new criteria to decide if a node should use epoch's first block to derive active set:
  90% of its epoch active set do not have acceptable grade
@bors
Copy link

bors bot commented Aug 20, 2023

Build failed:

@countvonzero
Copy link
Contributor Author

bors merge

bors bot pushed a commit that referenced this pull request Aug 20, 2023
@countvonzero
miner oracle use ref ballot for active set (#4876)
a81c622 
## Motivation
Closes #4837
Closes #4838

## Changes
- use active set from ref ballot when available
- new criteria to decide if a node should use epoch's first block to derive active set:
  90% of its epoch active set do not have acceptable grade
@bors
Copy link

bors bot commented Aug 20, 2023

Build failed:

@countvonzero
Copy link
Contributor Author

bors merge

bors bot pushed a commit that referenced this pull request Aug 20, 2023
@countvonzero
miner oracle use ref ballot for active set (#4876)
9faafcf 
## Motivation
Closes #4837
Closes #4838

## Changes
- use active set from ref ballot when available
- new criteria to decide if a node should use epoch's first block to derive active set:
  90% of its epoch active set do not have acceptable grade
@bors
Copy link

bors bot commented Aug 20, 2023

Build failed:

@countvonzero
Copy link
Contributor Author

bors merge

bors bot pushed a commit that referenced this pull request Aug 20, 2023
@countvonzero
miner oracle use ref ballot for active set (#4876)
e532903 
## Motivation
Closes #4837
Closes #4838

## Changes
- use active set from ref ballot when available
- new criteria to decide if a node should use epoch's first block to derive active set:
  90% of its epoch active set do not have acceptable grade
@bors
Copy link

bors bot commented Aug 20, 2023

Build failed:

@countvonzero
Copy link
Contributor Author

bors merge

bors bot pushed a commit that referenced this pull request Aug 20, 2023
@countvonzero
miner oracle use ref ballot for active set (#4876)
b23bc52 
## Motivation
Closes #4837
Closes #4838

## Changes
- use active set from ref ballot when available
- new criteria to decide if a node should use epoch's first block to derive active set:
  90% of its epoch active set do not have acceptable grade
@bors
Copy link

bors bot commented Aug 20, 2023

Pull request successfully merged into develop.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title miner oracle use ref ballot for active set [Merged by Bors] - miner oracle use ref ballot for active set Aug 20, 2023
@bors bors bot closed this Aug 20, 2023
@countvonzero countvonzero deleted the better-syncness-check branch August 24, 2023 21:58
@countvonzero countvonzero restored the better-syncness-check branch August 24, 2023 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dshulyak dshulyak dshulyak approved these changes

@fasmat fasmat Awaiting requested review from fasmat fasmat is a code owner

@poszu poszu Awaiting requested review from poszu poszu is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@countvonzero @dshulyak