[Merged by Bors] - Make grpc servers' start methods be synchronous #4866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piersy
requested review from
countvonzero,
dshulyak,
fasmat and
poszu
as code owners
fasmat
approved these changes
Aug 17, 2023
poszu
reviewed
Aug 17, 2023
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Aug 17, 2023
## Motivation Closes #4861 ## Changes Updates grpc server startup code to execute synchronously, returning only after the server has started listening. ## Test Plan Existing tests should pass ## DevOps Notes <!-- Please uncheck these items as applicable to make DevOps aware of changes that may affect releases --> - [x] This PR does not require configuration changes (e.g., environment variables, GitHub secrets, VM resources) - [x] This PR does not affect public APIs - [x] This PR does not rely on a new version of external services (PoET, elasticsearch, etc.) - [x] This PR does not make changes to log messages (which monitoring infrastructure may rely on)
|
bors cancel |
|
Canceled. |
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Aug 17, 2023
## Motivation Closes #4861 ## Changes Updates grpc server startup code to execute synchronously, returning only after the server has started listening. ## Test Plan Existing tests should pass ## DevOps Notes <!-- Please uncheck these items as applicable to make DevOps aware of changes that may affect releases --> - [x] This PR does not require configuration changes (e.g., environment variables, GitHub secrets, VM resources) - [x] This PR does not affect public APIs - [x] This PR does not rely on a new version of external services (PoET, elasticsearch, etc.) - [x] This PR does not make changes to log messages (which monitoring infrastructure may rely on)
|
Build failed (retrying...): |
bors bot
pushed a commit
that referenced
this pull request
Aug 17, 2023
## Motivation Closes #4861 ## Changes Updates grpc server startup code to execute synchronously, returning only after the server has started listening. ## Test Plan Existing tests should pass ## DevOps Notes <!-- Please uncheck these items as applicable to make DevOps aware of changes that may affect releases --> - [x] This PR does not require configuration changes (e.g., environment variables, GitHub secrets, VM resources) - [x] This PR does not affect public APIs - [x] This PR does not rely on a new version of external services (PoET, elasticsearch, etc.) - [x] This PR does not make changes to log messages (which monitoring infrastructure may rely on)
|
Build failed: |
Remove erroneous blocking call to serve in grpc http server. Return error returned by grpc server Start methods. Fix bad peer test config.
piersy
force-pushed
the
piersy/grpcserver-synchronous-start
branch
from
19d609e
to
33808b6
Compare
Codecov Report
@@ Coverage Diff @@
## develop #4866 +/- ##
=========================================
- Coverage 76.9% 76.8% -0.1%
=========================================
Files 261 261
Lines 30103 30091 -12
=========================================
- Hits 23166 23128 -38
- Misses 5453 5474 +21
- Partials 1484 1489 +5
|
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Aug 18, 2023
## Motivation Closes #4861 ## Changes Updates grpc server startup code to execute synchronously, returning only after the server has started listening. ## Test Plan Existing tests should pass ## DevOps Notes <!-- Please uncheck these items as applicable to make DevOps aware of changes that may affect releases --> - [x] This PR does not require configuration changes (e.g., environment variables, GitHub secrets, VM resources) - [x] This PR does not affect public APIs - [x] This PR does not rely on a new version of external services (PoET, elasticsearch, etc.) - [x] This PR does not make changes to log messages (which monitoring infrastructure may rely on)
|
Pull request successfully merged into develop. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #4861
Changes
Updates grpc server startup code to execute synchronously, returning only after the server has started listening.
Test Plan
Existing tests should pass
DevOps Notes