[Merged by Bors] - fetch: requests got lost when there are no peers #4849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dshulyak
approved these changes
Aug 15, 2023
| updates: rlayers( | ||
| rlayer(start, rblock(idg("1"), fixture.Valid(), fixture.Data())), | ||
| rlayer(start+1, rblock(idg("2"), fixture.Valid(), fixture.Data())), | ||
| rlayer(start+2, rblock(idg("3"), fixture.Valid())), |
There was a problem hiding this comment.
maybe extend it with one more block with data? and one more call that both got applied
fetch/fetch.go
Outdated
| log.Stringer("hash", msg.Hash), | ||
| log.String("hint", string(msg.Hint)), | ||
| ) | ||
| f.unprocessed[msg.Hash] = req |
There was a problem hiding this comment.
so GetBlocks will not return immediately with error if no peers, but instead we will do the request when peers are available?
There was a problem hiding this comment.
yes. essentially put those requests back to the queue
There was a problem hiding this comment.
do you prefer to fail all in that case?
There was a problem hiding this comment.
this approach is fine for me too, hard to tell what is better
There was a problem hiding this comment.
actually i prefer returning error right away. it's easier for debugging (and avoiding future bug)
Codecov Report
@@ Coverage Diff @@
## develop #4849 +/- ##
=========================================
- Coverage 76.9% 76.8% -0.1%
=========================================
Files 261 261
Lines 29689 29720 +31
=========================================
+ Hits 22831 22850 +19
- Misses 5406 5418 +12
Partials 1452 1452
|
|
bors try |
tryBuild failed: |
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Aug 16, 2023
## Motivation requests are not restored back to the queue when there were no peers to dispatch to. ## Changes - restore requests when there are no peers - push mesh to still make progress even when there are missing blocks - increase frequency of state sync ## testing i manually test against mainnet, artificially causing GetPeers() to return zero peers. mesh was making very slow progress because it aborts as soon as it finds a missing block, not executing the next block even when it's available.
|
Build failed: |
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Aug 16, 2023
## Motivation requests are not restored back to the queue when there were no peers to dispatch to. ## Changes - restore requests when there are no peers - push mesh to still make progress even when there are missing blocks - increase frequency of state sync ## testing i manually test against mainnet, artificially causing GetPeers() to return zero peers. mesh was making very slow progress because it aborts as soon as it finds a missing block, not executing the next block even when it's available.
|
Pull request successfully merged into develop. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
bors
bot
changed the title
countvonzero
added a commit
that referenced
this pull request
Aug 16, 2023
requests are not restored back to the queue when there were no peers to dispatch to. - restore requests when there are no peers - push mesh to still make progress even when there are missing blocks - increase frequency of state sync i manually test against mainnet, artificially causing GetPeers() to return zero peers. mesh was making very slow progress because it aborts as soon as it finds a missing block, not executing the next block even when it's available.
brunovale91
pushed a commit
to swarmbit/go-spacemesh
that referenced
this pull request
Aug 21, 2023
requests are not restored back to the queue when there were no peers to dispatch to. - restore requests when there are no peers - push mesh to still make progress even when there are missing blocks - increase frequency of state sync i manually test against mainnet, artificially causing GetPeers() to return zero peers. mesh was making very slow progress because it aborts as soon as it finds a missing block, not executing the next block even when it's available.
brunovale91
pushed a commit
to swarmbit/go-spacemesh
that referenced
this pull request
Aug 21, 2023
requests are not restored back to the queue when there were no peers to dispatch to. - restore requests when there are no peers - push mesh to still make progress even when there are missing blocks - increase frequency of state sync i manually test against mainnet, artificially causing GetPeers() to return zero peers. mesh was making very slow progress because it aborts as soon as it finds a missing block, not executing the next block even when it's available.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
requests are not restored back to the queue when there were no peers to dispatch to.
Changes
testing
i manually test against mainnet, artificially causing GetPeers() to return zero peers.
mesh was making very slow progress because it aborts as soon as it finds a missing block, not executing the next block even when it's available.