Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - p2p: add ip4/ip6 blocklists #4795

Closed
wants to merge 6 commits into from

Conversation

dshulyak
Copy link
Contributor

@dshulyak dshulyak commented Aug 9, 2023

closes: #4788

default ip4/ip6 blocked ranges https://github.com/spacemeshos/go-spacemesh/blob/a8f86a19fffde6141110b21d398b65bf017d2c57/p2p/host.go#L48-L66C1

to disable them set "ip4-blocklist": [] or "ip6-blocklist": [] in config.
if private-network is set to true, blocklists will be ignored. that option meant to be used only in testing networks.
direct peers will bypass blocklists validation.

@dshulyak dshulyak requested a review from pigmej August 9, 2023 09:28
@dshulyak dshulyak marked this pull request as ready for review August 9, 2023 09:28
p2p/gater.go Outdated Show resolved Hide resolved
p2p/gater.go Outdated Show resolved Hide resolved
Copy link
Member

@pigmej pigmej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me.

@dshulyak
Copy link
Contributor Author

bors merge

bors bot pushed a commit that referenced this pull request Aug 22, 2023
closes: #4788

default ip4/ip6 blocked ranges https://github.com/spacemeshos/go-spacemesh/blob/a8f86a19fffde6141110b21d398b65bf017d2c57/p2p/host.go#L48-L66C1

to disable them set `"ip4-blocklist": []` or `"ip6-blocklist": []` in config. 
if `private-network` is set to true, blocklists will be ignored. that option meant to be used only in testing networks.
`direct` peers will bypass blocklists validation.
@bors
Copy link

bors bot commented Aug 22, 2023

Pull request successfully merged into develop.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title p2p: add ip4/ip6 blocklists [Merged by Bors] - p2p: add ip4/ip6 blocklists Aug 22, 2023
@bors bors bot closed this Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make possible to disable local network scanning in discovery in the config
3 participants