New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - beacon: handle malicious identity #4779
[Merged by Bors] - beacon: handle malicious identity #4779
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #4779 +/- ##
=========================================
- Coverage 76.8% 76.8% -0.1%
=========================================
Files 259 259
Lines 29491 29522 +31
=========================================
+ Hits 22659 22680 +21
- Misses 5392 5400 +8
- Partials 1440 1442 +2
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
doesn't it require grading too? otherwise how we can be sure that malicious identities are seen the same way
i specifically asked Tal/Iddo in barcelona. they said it only requires 2 grades going into the protocol. (malicious or not) because this is tortoise style consensus. (i don't fully understand why but tortoise did only use 2 grades). so i only count identities that are malicious before the protocol starts. |
bors merge |
## Motivation Closes #4772 ## Changes for malicious identity's - proposal: categorized as potentially valid (voting against) - first vote: accept with weight 0 - following vote: accept with weight 0 malicious identity's weight is not included in the total epoch weight
Build failed: |
bors merge |
## Motivation Closes #4772 ## Changes for malicious identity's - proposal: categorized as potentially valid (voting against) - first vote: accept with weight 0 - following vote: accept with weight 0 malicious identity's weight is not included in the total epoch weight
Pull request successfully merged into develop. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
Motivation
Closes #4772
Changes
for malicious identity's
malicious identity's weight is not included in the total epoch weight