Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - beacon: handle malicious identity #4779

Closed

Conversation

countvonzero
Copy link
Contributor

@countvonzero countvonzero commented Aug 5, 2023

Motivation

Closes #4772

Changes

for malicious identity's

  • proposal: categorized as potentially valid (voting against)
  • first vote: accept with weight 0
  • following vote: accept with weight 0

malicious identity's weight is not included in the total epoch weight

@codecov
Copy link

codecov bot commented Aug 5, 2023

Codecov Report

Merging #4779 (5e67025) into develop (6a4208b) will decrease coverage by 0.1%.
Report is 2 commits behind head on develop.
The diff coverage is 79.2%.

@@            Coverage Diff            @@
##           develop   #4779     +/-   ##
=========================================
- Coverage     76.8%   76.8%   -0.1%     
=========================================
  Files          259     259             
  Lines        29491   29522     +31     
=========================================
+ Hits         22659   22680     +21     
- Misses        5392    5400      +8     
- Partials      1440    1442      +2     
Files Changed Coverage Δ
beacon/metrics/prometheus.go 87.7% <ø> (ø)
beacon/state.go 100.0% <ø> (ø)
beacon/beacon.go 79.4% <66.6%> (-0.1%) ⬇️
beacon/handlers.go 86.7% <100.0%> (+0.4%) ⬆️

... and 2 files with indirect coverage changes

Copy link
Contributor

@dshulyak dshulyak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't it require grading too? otherwise how we can be sure that malicious identities are seen the same way

@countvonzero
Copy link
Contributor Author

doesn't it require grading too? otherwise how we can be sure that malicious identities are seen the same way

i specifically asked Tal/Iddo in barcelona. they said it only requires 2 grades going into the protocol. (malicious or not) because this is tortoise style consensus. (i don't fully understand why but tortoise did only use 2 grades).

so i only count identities that are malicious before the protocol starts.

@countvonzero
Copy link
Contributor Author

bors merge

bors bot pushed a commit that referenced this pull request Aug 7, 2023
## Motivation
Closes #4772

## Changes
for malicious identity's 
- proposal: categorized as potentially valid (voting against)
- first vote: accept with weight 0
- following vote: accept with weight 0

malicious identity's weight is not included in the total epoch weight
@bors
Copy link

bors bot commented Aug 7, 2023

Build failed:

@countvonzero
Copy link
Contributor Author

bors merge

bors bot pushed a commit that referenced this pull request Aug 7, 2023
## Motivation
Closes #4772

## Changes
for malicious identity's 
- proposal: categorized as potentially valid (voting against)
- first vote: accept with weight 0
- following vote: accept with weight 0

malicious identity's weight is not included in the total epoch weight
@bors
Copy link

bors bot commented Aug 7, 2023

Pull request successfully merged into develop.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title beacon: handle malicious identity [Merged by Bors] - beacon: handle malicious identity Aug 7, 2023
@bors bors bot closed this Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

beacon: vote against proposal from malicious identities
2 participants