Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - p2p: disable autoscaling and drop from bootnodes on enough peers #4770

Closed
wants to merge 3 commits into from

Conversation

dshulyak
Copy link
Contributor

@dshulyak dshulyak commented Aug 3, 2023

related: #4771

total hardcap without autoscaling should be high peers + min peers + transient new connections (min peers).
once node reached high-peers watermark, it will disconnect from bootnodes, and reconnect only once crossing min-peers watermark

@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Merging #4770 (053874f) into develop (05e1351) will decrease coverage by 0.1%.
The diff coverage is 29.1%.

@@            Coverage Diff            @@
##           develop   #4770     +/-   ##
=========================================
- Coverage     76.8%   76.8%   -0.1%     
=========================================
  Files          259     259             
  Lines        29432   29452     +20     
=========================================
+ Hits         22623   22635     +12     
- Misses        5373    5380      +7     
- Partials      1436    1437      +1     
Files Changed Coverage Δ
p2p/host.go 34.3% <0.0%> (-1.6%) ⬇️
p2p/dhtdiscovery/discovery.go 76.0% <45.4%> (+5.0%) ⬆️
p2p/upgrade.go 69.1% <100.0%> (+0.5%) ⬆️

... and 6 files with indirect coverage changes

@dshulyak dshulyak changed the title p2p: disable autoscaling p2p: disable autoscaling and drop from bootnodes on enough peers Aug 3, 2023
@dshulyak dshulyak marked this pull request as ready for review August 3, 2023 10:16
@pigmej pigmej self-requested a review August 3, 2023 10:18
@pigmej
Copy link
Member

pigmej commented Aug 3, 2023

I have run it on several nodes number of connections was under the control.

@dshulyak
Copy link
Contributor Author

dshulyak commented Aug 3, 2023

bors merge

bors bot pushed a commit that referenced this pull request Aug 3, 2023
related: https://github.com/spacemeshos/smapp/issues/1424

total hardcap without autoscaling should be high peers + min peers + transient new connections (min peers).
once node reached high-peers watermark, it will disconnect from bootnodes, and reconnect only once crossing min-peers watermark
@bors
Copy link

bors bot commented Aug 3, 2023

Pull request successfully merged into develop.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title p2p: disable autoscaling and drop from bootnodes on enough peers [Merged by Bors] - p2p: disable autoscaling and drop from bootnodes on enough peers Aug 3, 2023
@bors bors bot closed this Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants