Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - p2p: add configuration for direct peers #4769

Closed
wants to merge 4 commits into from

Conversation

dshulyak
Copy link
Contributor

@dshulyak dshulyak commented Aug 3, 2023

@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Merging #4769 (7066feb) into develop (366da6d) will decrease coverage by 0.1%.
The diff coverage is 29.5%.

@@            Coverage Diff            @@
##           develop   #4769     +/-   ##
=========================================
- Coverage     76.8%   76.7%   -0.1%     
=========================================
  Files          259     259             
  Lines        29452   29488     +36     
=========================================
+ Hits         22633   22646     +13     
- Misses        5381    5399     +18     
- Partials      1438    1443      +5     
Files Changed Coverage Δ
p2p/host.go 34.3% <ø> (ø)
p2p/upgrade.go 65.1% <25.0%> (-4.0%) ⬇️
p2p/dhtdiscovery/discovery.go 70.4% <29.0%> (-5.7%) ⬇️
p2p/pubsub/pubsub.go 87.6% <100.0%> (+0.1%) ⬆️

... and 5 files with indirect coverage changes

@dshulyak
Copy link
Contributor Author

dshulyak commented Aug 3, 2023

bors merge

bors bot pushed a commit that referenced this pull request Aug 3, 2023
direct peers are not pruned, and node will always try to establish connections with them
regardless of the current number of connections.

configuration is in p2p section, same format for address as bootnodes
```json
"p2p": {
    "direct": []
}
```
@bors
Copy link

bors bot commented Aug 3, 2023

Build failed:

@dshulyak
Copy link
Contributor Author

dshulyak commented Aug 3, 2023

bors merge

bors bot pushed a commit that referenced this pull request Aug 3, 2023
direct peers are not pruned, and node will always try to establish connections with them
regardless of the current number of connections.

configuration is in p2p section, same format for address as bootnodes
```json
"p2p": {
    "direct": []
}
```
@bors
Copy link

bors bot commented Aug 3, 2023

Build failed:

@dshulyak dshulyak marked this pull request as draft August 3, 2023 11:33
@dshulyak dshulyak marked this pull request as ready for review August 4, 2023 06:40
@dshulyak
Copy link
Contributor Author

dshulyak commented Aug 4, 2023

bors try

bors bot added a commit that referenced this pull request Aug 4, 2023
@bors
Copy link

bors bot commented Aug 4, 2023

try

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@dshulyak
Copy link
Contributor Author

dshulyak commented Aug 4, 2023

bors merge

@bors
Copy link

bors bot commented Aug 4, 2023

Pull request successfully merged into develop.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title p2p: add configuration for direct peers [Merged by Bors] - p2p: add configuration for direct peers Aug 4, 2023
@bors bors bot closed this Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants