[Merged by Bors] - Fix logging issues in TestSpacemeshApp_NodeService #4763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fasmat
force-pushed
the
fix-logging-tests
branch
from
0a94619
to
df19596
Compare
dshulyak
approved these changes
Aug 1, 2023
Codecov Report
@@ Coverage Diff @@
## develop #4763 +/- ##
=========================================
- Coverage 76.8% 76.8% -0.1%
=========================================
Files 259 259
Lines 29431 29432 +1
=========================================
- Hits 22623 22619 -4
- Misses 5372 5377 +5
Partials 1436 1436
|
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Aug 1, 2023
## Motivation `TestSpacemeshApp_NodeService` has been flaky recently. The issues were caused by how libp2p does logging and a missing cleanup of the internal clock during the test. ## Changes - remove custom clock in test - it is overwritten anyway by calling `app.Start()` later in the test - ensure the global logger used by libp2p is set to a no-op logger when the node is shut down (via `p2p.Host::Stop()`) ## Test Plan n/a ## TODO <!-- This section should be removed when all items are complete --> - [x] Explain motivation or link existing issue(s) - [x] Test changes and document test plan - [x] Update documentation as needed ## DevOps Notes <!-- Please uncheck these items as applicable to make DevOps aware of changes that may affect releases --> - [x] This PR does not require configuration changes (e.g., environment variables, GitHub secrets, VM resources) - [x] This PR does not affect public APIs - [x] This PR does not rely on a new version of external services (PoET, elasticsearch, etc.) - [x] This PR does not make changes to log messages (which monitoring infrastructure may rely on)
|
Pull request successfully merged into develop. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
TestSpacemeshApp_NodeServicehas been flaky recently. The issues were caused by how libp2p does logging and a missing cleanup of the internal clock during the test.Changes
app.Start()later in the testp2p.Host::Stop())Test Plan
n/a
TODO
DevOps Notes