[Merged by Bors] - Remove global logger #4749
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #4749 +/- ##
=========================================
- Coverage 77.1% 76.9% -0.3%
=========================================
Files 255 259 +4
Lines 28886 29306 +420
=========================================
+ Hits 22284 22547 +263
- Misses 5209 5332 +123
- Partials 1393 1427 +34
|
|
bors try |
tryBuild succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
poszu
reviewed
Jul 31, 2023
poszu
approved these changes
Aug 1, 2023
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Aug 1, 2023
## Motivation Using a global logger makes testing harder and logging configuration more complicated. This PR removes most uses of the global logger to address this. ## Changes - Instead of the global logger services now use their own logging instance, this should reduce the number of log lines produced by `0000.defaultLogger` - There are still a few places where the global logger is used, primarily the `common/types` package where it cannot be replaced without some bigger changes. Issue for this: #4751 ## Test Plan n/a ## TODO <!-- This section should be removed when all items are complete --> - [x] Explain motivation or link existing issue(s) - [x] Test changes and document test plan - [x] Update documentation as needed ## DevOps Notes <!-- Please uncheck these items as applicable to make DevOps aware of changes that may affect releases --> - [x] This PR does not require configuration changes (e.g., environment variables, GitHub secrets, VM resources) - [x] This PR does not affect public APIs - [x] This PR does not rely on a new version of external services (PoET, elasticsearch, etc.) - [x] This PR does not make changes to log messages (which monitoring infrastructure may rely on)
|
bors merge |
|
Already running a review |
|
Pull request successfully merged into develop. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Using a global logger makes testing harder and logging configuration more complicated. This PR removes most uses of the global logger to address this.
Changes
0000.defaultLoggercommon/typespackage where it cannot be replaced without some bigger changes. Issue for this: logging: remove global logger #4751Test Plan
n/a
TODO
DevOps Notes