Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Default (nonces, threads) = (288, CPU*3/4) for Mainnet #4741

Closed
wants to merge 2 commits into from

Conversation

poszu
Copy link
Contributor

@poszu poszu commented Jul 22, 2023

No description provided.

@codecov
Copy link

codecov bot commented Jul 22, 2023

Codecov Report

Merging #4741 (cedbe71) into develop (0bd65e1) will increase coverage by 0.0%.
The diff coverage is 62.5%.

@@           Coverage Diff           @@
##           develop   #4741   +/-   ##
=======================================
  Coverage     77.1%   77.1%           
=======================================
  Files          255     255           
  Lines        28879   28886    +7     
=======================================
+ Hits         22286   22292    +6     
  Misses        5202    5202           
- Partials      1391    1392    +1     
Impacted Files Coverage Δ
config/mainnet.go 95.2% <62.5%> (-2.7%) ⬇️

... and 1 file with indirect coverage changes

@poszu
Copy link
Contributor Author

poszu commented Jul 22, 2023

Perhaps we should set threads to all cores on low end CPU with not many cores?

@pigmej
Copy link
Member

pigmej commented Jul 22, 2023

It will be hard to predict and still some spare for the system needed imho:)

@pigmej
Copy link
Member

pigmej commented Jul 22, 2023

bors merge

@bors
Copy link

bors bot commented Jul 22, 2023

Build failed:

@fasmat
Copy link
Member

fasmat commented Jul 22, 2023

bors merge

@bors
Copy link

bors bot commented Jul 22, 2023

Canceled.

@countvonzero
Copy link
Contributor

bors merge

bors bot pushed a commit that referenced this pull request Jul 22, 2023
Co-authored-by: kimmy lin <30611210+countvonzero@users.noreply.github.com>
config/presets/fastnet.go Outdated Show resolved Hide resolved
@bors
Copy link

bors bot commented Jul 22, 2023

Build failed:

@countvonzero countvonzero force-pushed the mainnet-proving-nonces-threads-defaults branch from b3b59a3 to 45b5fbe Compare July 22, 2023 20:10
@fasmat fasmat force-pushed the mainnet-proving-nonces-threads-defaults branch from 609da2f to cedbe71 Compare July 22, 2023 20:12
@fasmat
Copy link
Member

fasmat commented Jul 22, 2023

bors merge

bors bot pushed a commit that referenced this pull request Jul 22, 2023
Co-authored-by: Matthias <5011972+fasmat@users.noreply.github.com>
@bors
Copy link

bors bot commented Jul 22, 2023

Build failed:

  • ci-status

@fasmat
Copy link
Member

fasmat commented Jul 22, 2023

bors merge

bors bot pushed a commit that referenced this pull request Jul 22, 2023
Co-authored-by: Matthias <5011972+fasmat@users.noreply.github.com>
@bors
Copy link

bors bot commented Jul 22, 2023

Pull request successfully merged into develop.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title Default (nonces, threads) = (288, CPU*3/4) for Mainnet [Merged by Bors] - Default (nonces, threads) = (288, CPU*3/4) for Mainnet Jul 22, 2023
@bors bors bot closed this Jul 22, 2023
@bors bors bot deleted the mainnet-proving-nonces-threads-defaults branch July 22, 2023 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants