Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - config: add public metrics group #4737

Closed
wants to merge 1 commit into from

Conversation

dshulyak
Copy link
Contributor

the config now is

{
    "public-metrics": {
        "metrics-push": "https://public-metrics-gateway.spacemesh.network",
        "metrics-push-period": "1s",
        "metrics-push-user": "xxx",
        "metrics-push-pass": "xxx",
        "metrics-push-header": {
          "X-Scope-OrgId": "xxx-xxx"
        }
    }
}

to disable either remove whole config, or set metrics-push value to empty string

@dshulyak dshulyak requested a review from pigmej July 21, 2023 10:50
@dshulyak dshulyak changed the title connfig: add public metrics group config: add public metrics group Jul 21, 2023
@codecov
Copy link

codecov bot commented Jul 21, 2023

Codecov Report

Merging #4737 (fa516b7) into develop (e91d735) will increase coverage by 0.0%.
The diff coverage is 0.0%.

@@           Coverage Diff           @@
##           develop   #4737   +/-   ##
=======================================
  Coverage     77.2%   77.2%           
=======================================
  Files          255     255           
  Lines        28855   28852    -3     
=======================================
- Hits         22279   22278    -1     
+ Misses        5190    5188    -2     
  Partials      1386    1386           
Impacted Files Coverage Δ
config/config.go 100.0% <ø> (ø)
config/mainnet.go 97.9% <ø> (-0.1%) ⬇️
node/node.go 65.5% <0.0%> (ø)

... and 3 files with indirect coverage changes

@dshulyak
Copy link
Contributor Author

bors merge

bors bot pushed a commit that referenced this pull request Jul 21, 2023
the config now is 
```json

{
    "public-metrics": {
        "metrics-push": "https://public-metrics-gateway.spacemesh.network",
        "metrics-push-period": "1s",
        "metrics-push-user": "xxx",
        "metrics-push-pass": "xxx",
        "metrics-push-header": {
          "X-Scope-OrgId": "xxx-xxx"
        }
    }
}
```


to disable either remove whole config, or set metrics-push value to empty string
@bors
Copy link

bors bot commented Jul 21, 2023

Pull request successfully merged into develop.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title config: add public metrics group [Merged by Bors] - config: add public metrics group Jul 21, 2023
@bors bors bot closed this Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants