[Merged by Bors] - Clean up all files upon stop smeshing #4732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #4732 +/- ##
=========================================
- Coverage 77.2% 77.1% -0.1%
=========================================
Files 255 255
Lines 28855 28879 +24
=========================================
+ Hits 22279 22293 +14
- Misses 5190 5197 +7
- Partials 1386 1389 +3
|
countvonzero
approved these changes
Jul 21, 2023
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Jul 21, 2023
## Motivation
To avoid publishing incorrect proofs after a user re-initializes cleanup all local state when `deleteFiles` is set to `true`.
## Changes
Delete all state not just post upon StopSmeshing { deleteFiles: true }.
## Test Plan
n/a
## TODO
<!-- This section should be removed when all items are complete -->
- [x] Explain motivation or link existing issue(s)
- [x] Test changes and document test plan
- [x] Update documentation as needed
## DevOps Notes
<!-- Please uncheck these items as applicable to make DevOps aware of changes that may affect releases -->
- [x] This PR does not require configuration changes (e.g., environment variables, GitHub secrets, VM resources)
- [x] This PR does not affect public APIs
- [x] This PR does not rely on a new version of external services (PoET, elasticsearch, etc.)
- [x] This PR does not make changes to log messages (which monitoring infrastructure may rely on)
|
Pull request successfully merged into develop. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
To avoid publishing incorrect proofs after a user re-initializes cleanup all local state when
deleteFilesis set totrue.Changes
Delete all state not just post upon StopSmeshing { deleteFiles: true }.
Test Plan
n/a
TODO
DevOps Notes