Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Proving opts metrics #4726

Closed
wants to merge 1 commit into from
Closed

Conversation

poszu
Copy link
Contributor

@poszu poszu commented Jul 19, 2023

Motivation

Add public metrics with smeshing proving opts - nonces and threads.

@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

Merging #4726 (f14864d) into develop (0a9b323) will decrease coverage by 0.1%.
The diff coverage is 100.0%.

@@            Coverage Diff            @@
##           develop   #4726     +/-   ##
=========================================
- Coverage     77.2%   77.2%   -0.1%     
=========================================
  Files          255     255             
  Lines        28839   28841      +2     
=========================================
  Hits         22270   22270             
- Misses        5182    5183      +1     
- Partials      1387    1388      +1     
Impacted Files Coverage Δ
node/node.go 65.5% <100.0%> (+<0.1%) ⬆️

... and 2 files with indirect coverage changes

Copy link
Member

@pigmej pigmej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conceptually ok.

@poszu
Copy link
Contributor Author

poszu commented Jul 19, 2023

bors merge

bors bot pushed a commit that referenced this pull request Jul 19, 2023
## Motivation
Add public metrics with smeshing proving opts - nonces and threads.
@bors
Copy link

bors bot commented Jul 19, 2023

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Jul 19, 2023
## Motivation
Add public metrics with smeshing proving opts - nonces and threads.
@bors
Copy link

bors bot commented Jul 19, 2023

Pull request successfully merged into develop.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title Proving opts metrics [Merged by Bors] - Proving opts metrics Jul 19, 2023
@bors bors bot closed this Jul 19, 2023
@bors bors bot deleted the proving-opts-metrics branch July 19, 2023 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants