[Merged by Bors] - public metrics #4723
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #4723 +/- ##
=========================================
- Coverage 77.2% 77.1% -0.1%
=========================================
Files 255 255
Lines 28805 28825 +20
=========================================
+ Hits 22246 22252 +6
- Misses 5171 5182 +11
- Partials 1388 1391 +3
|
| app.Config.MetricsPushPass, | ||
| app.Config.MetricsPushHeader, | ||
| app.Config.MetricsPushPeriod, | ||
| app.host.ID().String()[:5], app.Config.Genesis.GenesisID().ShortString()) |
There was a problem hiding this comment.
what do you think about hashing the first 5 char?
There was a problem hiding this comment.
maybe hash all then and use 5 chars? i can do
There was a problem hiding this comment.
actually it doesn't hide anything, if i want i can hash all identities found in the network and match them
There was a problem hiding this comment.
yes. but at least its a step towards anomynizing. somebody have to pay the computation to get it....
There was a problem hiding this comment.
But the same info will be publicly available in the epoch when ATX will be published, right? So why are we trying to hide it?
|
bors merge |
subset of metrics to record:
- connections
- version
- init size started / completed
- post proof time
they will be recorded with 5 first characters from p2p public key, we probably don't want to gather information about smesher key.
example config:
```json
{
"main": {
"metrics-push": "https://public-metrics-gateway.spacemesh.dev/",
"metrics-push-period": "1s",
"metrics-push-user": "XXX",
"metrics-push-pass": "XXXXXX",
"metrics-push-header": {
"X-Scope-OrgId": "XXXXXXX"
}
}
}
```
|
Pull request successfully merged into develop. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
subset of metrics to record:
they will be recorded with 5 first characters from p2p public key, we probably don't want to gather information about smesher key.
example config:
{ "main": { "metrics-push": "https://public-metrics-gateway.spacemesh.dev/", "metrics-push-period": "1s", "metrics-push-user": "XXX", "metrics-push-pass": "XXXXXX", "metrics-push-header": { "X-Scope-OrgId": "XXXXXXX" } } }