[Merged by Bors] - Verify self-generated POST proofs to catch errors early #4721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poszu
commented
Jul 18, 2023
| @@ -211,6 +212,7 @@ func (b *Builder) StartSmeshing(coinbase types.Address, opts PostSetupOpts) erro | |||
| return nil | |||
| case err != nil: | |||
| b.log.Panic("initialization failed: %v", err) | |||
| return err | |||
There was a problem hiding this comment.
Note: this is only needed to pass the unit test that mocks log.Panic... (and doesn't actually panic, allowing the code to proceed)
fasmat
reviewed
Jul 18, 2023
Codecov Report
@@ Coverage Diff @@
## develop #4721 +/- ##
=======================================
Coverage 77.3% 77.3%
=======================================
Files 255 255
Lines 28724 28784 +60
=======================================
+ Hits 22207 22257 +50
- Misses 5132 5141 +9
- Partials 1385 1386 +1
|
fasmat
reviewed
Jul 18, 2023
countvonzero
approved these changes
Jul 18, 2023
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Jul 18, 2023
## Motivation Currently, if a node generated invalid POST proof (possibly because it has invalid POST data), it will learn it after Poet round ended (2 weeks) - upon publishing the ATX. It's suboptimal, we can check the proof right after it was created to give the operator more time to react. ## Changes Verify the generated POST proofs immediately after they are created. ## Test Plan - UT - system test - [x] manual test joining the mainnet
|
Pull request successfully merged into develop. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, if a node generated invalid POST proof (possibly because it has invalid POST data), it will learn it after Poet round ended (2 weeks) - upon publishing the ATX. It's suboptimal, we can check the proof right after it was created to give the operator more time to react.
Changes
Verify the generated POST proofs immediately after they are created.
Test Plan