[Merged by Bors] - use atx grading for hare

[countvonzero]

Motivation

Closes #4089
Closes #4757

Changes

• hare only vote for proposals with grade 1/acceptable and 2/good atxs in the activeset

[codecov]

Codecov Report

Merging #4718 (334d91b) into develop (a873af8) will decrease coverage by 0.1%.
The diff coverage is 48.7%.

❗ Current head 334d91b differs from pull request most recent head ba914a7. Consider uploading reports for the commit ba914a7 to get more accurate results

@@            Coverage Diff            @@
##           develop   #4718     +/-   ##
=========================================
- Coverage     76.9%   76.9%   -0.1%     
=========================================
  Files          259     259             
  Lines        29297   29361     +64     
=========================================
+ Hits         22557   22579     +22     
- Misses        5315    5351     +36     
- Partials      1425    1431      +6     

Files Changed	Coverage Δ
hare/hare.go	75.7% <41.1%> (-4.7%)	⬇️
hare/eligibility/oracle.go	73.3% <100.0%> (ø)
miner/oracle.go	74.4% <100.0%> (+0.5%)	⬆️
miner/util.go	71.4% <100.0%> (ø)

... and 5 files with indirect coverage changes

[dshulyak]

this function can be more generic to make it reusable, i think there is no need for it to load malfeasance proof.
there could be one more on top that loads it and can error

func GradeAtx(atxReceived, proofReceived, epochStart time.Time, delta time.Duration) Grade

[dshulyak]

can we add two more grades? it also makes sense to call them Grade1-5 explicitly, as this Evil/Acceptable/Good won't work anymore

i don't remember deltas in those grades, but there should be a picture somewhere

[dshulyak]

i realized that we don't persist grades, so it doesn't matter that much if this change is 3-graded or 5-graded

[countvonzero]

bors merge

[bors]

Pull request successfully merged into develop.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

• ci-status
• systest-status