Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - post: update to latest version with inflight verification #4716

Closed
wants to merge 6 commits into from

Conversation

fasmat
Copy link
Member

@fasmat fasmat commented Jul 17, 2023

Motivation

Closes spacemeshos/post#181

Changes

Updates PoST with inflight verification of labels

Test Plan

n/a

TODO

  • Explain motivation or link existing issue(s)
  • Test changes and document test plan
  • Update documentation as needed

DevOps Notes

  • This PR does not require configuration changes (e.g., environment variables, GitHub secrets, VM resources)
  • This PR does not affect public APIs
  • This PR does not rely on a new version of external services (PoET, elasticsearch, etc.)
  • This PR does not make changes to log messages (which monitoring infrastructure may rely on)

@fasmat fasmat self-assigned this Jul 17, 2023
@codecov
Copy link

codecov bot commented Jul 17, 2023

Codecov Report

Merging #4716 (025ef2f) into develop (c40a4ab) will decrease coverage by 0.1%.
The diff coverage is 17.3%.

@@            Coverage Diff            @@
##           develop   #4716     +/-   ##
=========================================
- Coverage     77.3%   77.3%   -0.1%     
=========================================
  Files          255     255             
  Lines        28724   28745     +21     
=========================================
+ Hits         22207   22220     +13     
- Misses        5132    5144     +12     
+ Partials      1385    1381      -4     
Impacted Files Coverage Δ
events/events.go 89.9% <13.3%> (-8.1%) ⬇️
activation/post.go 84.8% <25.0%> (-1.6%) ⬇️

... and 5 files with indirect coverage changes

@fasmat fasmat force-pushed the post-181-communicate-failing-labelcalculation branch 2 times, most recently from a214f17 to 9915464 Compare July 17, 2023 15:59
@fasmat fasmat changed the title Update post reference post: update to latest version with inflight verification Jul 18, 2023
@fasmat fasmat force-pushed the post-181-communicate-failing-labelcalculation branch from 136af9d to 025ef2f Compare July 18, 2023 16:14
@fasmat fasmat requested a review from pigmej July 18, 2023 16:19
@fasmat
Copy link
Member Author

fasmat commented Jul 18, 2023

bors merge

bors bot pushed a commit that referenced this pull request Jul 18, 2023
## Motivation
Closes spacemeshos/post#181

## Changes
Updates PoST with inflight verification of labels

## Test Plan
n/a

## TODO
<!-- This section should be removed when all items are complete -->
- [x] Explain motivation or link existing issue(s)
- [x] Test changes and document test plan
- [x] Update documentation as needed

## DevOps Notes
<!-- Please uncheck these items as applicable to make DevOps aware of changes that may affect releases -->
- [x] This PR does not require configuration changes (e.g., environment variables, GitHub secrets, VM resources)
- [x] This PR does not affect public APIs
- [x] This PR does not rely on a new version of external services (PoET, elasticsearch, etc.)
- [x] This PR does not make changes to log messages (which monitoring infrastructure may rely on)
@bors
Copy link

bors bot commented Jul 18, 2023

Pull request successfully merged into develop.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title post: update to latest version with inflight verification [Merged by Bors] - post: update to latest version with inflight verification Jul 18, 2023
@bors bors bot closed this Jul 18, 2023
@bors bors bot deleted the post-181-communicate-failing-labelcalculation branch July 18, 2023 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Verify POS initialization inflight
2 participants