Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - p2p: set resource manager conn limits relative to high peers #4707

Closed
wants to merge 2 commits into from

Conversation

dshulyak
Copy link
Contributor

@dshulyak dshulyak commented Jul 14, 2023

No description provided.

@dshulyak dshulyak marked this pull request as draft July 14, 2023 13:10
@dshulyak dshulyak changed the base branch from peers-limit-v1.0 to develop July 14, 2023 13:10
@pigmej pigmej changed the title set resource manager conn limit to high peers DNM set resource manager conn limit to high peers Jul 14, 2023
@dshulyak dshulyak marked this pull request as ready for review July 14, 2023 13:12
@dshulyak dshulyak changed the title DNM set resource manager conn limit to high peers [NOT DRAFT BUT DONT MERGE] set resource manager conn limit to high peers Jul 14, 2023
@dshulyak
Copy link
Contributor Author

bors try

bors bot added a commit that referenced this pull request Jul 14, 2023
@pigmej pigmej self-requested a review July 14, 2023 14:02
Copy link
Member

@pigmej pigmej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's just for testing

@bors
Copy link

bors bot commented Jul 14, 2023

try

Build failed:

@dshulyak dshulyak marked this pull request as draft July 14, 2023 15:21
@dshulyak dshulyak changed the title [NOT DRAFT BUT DONT MERGE] set resource manager conn limit to high peers set resource manager conn limit to high peers Jul 14, 2023
@dshulyak dshulyak changed the title set resource manager conn limit to high peers p2p: set resource manager conn limits relative to high peers Jul 19, 2023
@dshulyak dshulyak marked this pull request as ready for review July 19, 2023 06:31
@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

Merging #4707 (210f70c) into develop (084a83a) will decrease coverage by 0.1%.
The diff coverage is 52.9%.

@@            Coverage Diff            @@
##           develop   #4707     +/-   ##
=========================================
- Coverage     77.2%   77.2%   -0.1%     
=========================================
  Files          254     255      +1     
  Lines        28623   28819    +196     
=========================================
+ Hits         22121   22250    +129     
- Misses        5123    5181     +58     
- Partials      1379    1388      +9     
Impacted Files Coverage Δ
p2p/host.go 44.5% <0.0%> (-7.2%) ⬇️
api/grpcserver/config.go 100.0% <100.0%> (ø)
config/mainnet.go 97.8% <100.0%> (+<0.1%) ⬆️
config/mainnet_accounts.go 100.0% <100.0%> (ø)
config/presets/fastnet.go 100.0% <100.0%> (ø)
config/presets/standalone.go 100.0% <100.0%> (ø)

... and 15 files with indirect coverage changes

@dshulyak
Copy link
Contributor Author

bors merge

@bors
Copy link

bors bot commented Jul 19, 2023

Pull request successfully merged into develop.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title p2p: set resource manager conn limits relative to high peers [Merged by Bors] - p2p: set resource manager conn limits relative to high peers Jul 19, 2023
@bors bors bot closed this Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants