Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - sql: remove rewards_coinbase_layer as it is created with primary #4696

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - sql: remove rewards_coinbase_layer as it is created with primary #4696

wants to merge 2 commits into from

Conversation

dshulyak
Copy link
Contributor

@dshulyak dshulyak commented Jul 13, 2023 •
edited

closes: #4691

@codecov
Copy link

codecov bot commented Jul 13, 2023 •
edited

Codecov Report

Merging #4696 (92d47bb) into develop (5403cb9) will decrease coverage by 0.1%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           develop   #4696     +/-   ##
=========================================
- Coverage     77.7%   77.7%   -0.1%     
=========================================
  Files          259     259             
  Lines        30495   30495             
=========================================
- Hits         23702   23697      -5     
- Misses        5301    5307      +6     
+ Partials      1492    1491      -1

see 5 files with indirect coverage changes

@dshulyak
Copy link
Contributor Author

bors merge

bors bot pushed a commit that referenced this pull request Jul 14, 2023
@dshulyak
sql: remove rewards_coinbase_layer as it is created with primary (#4696)
de7a973 
closes: #4691
@dshulyak
Copy link
Contributor Author

bors cancel

@bors
Copy link

bors bot commented Jul 14, 2023

Canceled.

@dshulyak
Copy link
Contributor Author

this actually needs to go into 0002_migration file

@fasmat fasmat self-requested a review July 14, 2023 08:43
@dshulyak
Copy link
Contributor Author

bors merge

bors bot pushed a commit that referenced this pull request Oct 13, 2023
@dshulyak
sql: remove rewards_coinbase_layer as it is created with primary (#4696)
66c8ba0 
closes: #4691
@bors
Copy link

bors bot commented Oct 13, 2023

Build failed:

@dshulyak
Copy link
Contributor Author

bors merge

bors bot pushed a commit that referenced this pull request Oct 13, 2023
@dshulyak
sql: remove rewards_coinbase_layer as it is created with primary (#4696)
16249aa 
closes: #4691
@bors
Copy link

bors bot commented Oct 13, 2023

Canceled.

@dshulyak
Copy link
Contributor Author

bors merge

bors bot pushed a commit that referenced this pull request Oct 13, 2023
@dshulyak
sql: remove rewards_coinbase_layer as it is created with primary (#4696)
9af2d85 
closes: #4691
@bors
Copy link

bors bot commented Oct 13, 2023

Pull request successfully merged into develop.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title sql: remove rewards_coinbase_layer as it is created with primary [Merged by Bors] - sql: remove rewards_coinbase_layer as it is created with primary Oct 13, 2023
@bors bors bot closed this Oct 13, 2023
dshulyak added a commit to dshulyak/go-spacemesh that referenced this pull request Oct 13, 2023
@dshulyak
sql: remove rewards_coinbase_layer as it is created with primary (spa…
ea1f755 
…cemeshos#4696)

closes: spacemeshos#4691
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@countvonzero countvonzero Awaiting requested review from countvonzero

@poszu poszu Awaiting requested review from poszu poszu is a code owner

@fasmat fasmat Awaiting requested review from fasmat fasmat is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

redundant index rewards_by_coinbase on table rewards
2 participants
@dshulyak @fasmat