fix: compare with 'in' operator #15
Merged
+314
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @tjdevries |
aryx
approved these changes
Jul 25, 2023
Duologic
commented
Jul 25, 2023
grammar.js
Outdated
Comment on lines
177
to
227
| //"[", $.expr, "]", | ||
| //":", | ||
| //$.expr, | ||
| $.field, |
There was a problem hiding this comment.
This is not entirely according to spec but it prevents a precedence issue for fieldnames in brackets { [fieldname]: value }. I found this when making PR #16 but solved by this change.
Duologic
commented
Jul 25, 2023
test/corpus/fieldname.txt
Outdated
Comment on lines
1
to
3
| ============================= | ||
| Resolve expr in fieldname key | ||
| ============================= |
There was a problem hiding this comment.
Test case from #16
Duologic
commented
Jul 25, 2023
Comment on lines
+52
to
+55
| { | ||
| ['item' + i](v): i + v | ||
| for i in std.range(0,10) | ||
| } |
There was a problem hiding this comment.
This isn't possible according to the specification but is correctly intepreted by jsonnet.
// a.jsonnet
local lib = {
['item' + i](v): i + v
for i in std.range(0, 10)
};
lib.item10(3)[I] ➜ jsonnet a.jsonnet
13
[I] ➜ cjsonnet a.jsonnet
13
[I] ➜ jrsonnet a.jsonnet
13
|
After you rebase, i'll take a look at this one as well. Sorry for the delay! |
Duologic
force-pushed
the
in_operator_only
branch
from
4707122 to
9f9d0c6
Compare
|
rebased |
|
@tjdevries let me know if there's something I can improve |
|
LGTM to me! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Binary op "in" comparison
'string' in objwasn't working properly, this PR adds it to the grammar.This PR also adds test for comparison and for loops as they both deal with the 'in' keyword.
Also fixes #13 (see comments)