Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sideEffects: false from packages with CSS modules #42220

Open
Tracked by #42217
valerybugakov opened this issue Sep 28, 2022 · 0 comments
Open
Tracked by #42217

Remove sideEffects: false from packages with CSS modules #42220

valerybugakov opened this issue Sep 28, 2022 · 0 comments
Labels
css-order-in-production frontend-platform Issues related to our frontend platform, owned collectively by our frontend crew.

Comments

@valerybugakov
Copy link
Member

valerybugakov commented Sep 28, 2022

Context

The CSS rules order in the production environment differs from what we have in the development env because of the combination of the mini-css-plugin and sideEffects: false.

See this comment on the unresolved issue:

In addition to that, mini-css-plugin makes no strong guarantee about the order of independent CSS files. It tries its best to keep the importing order, but there are some cases where this is not followed, e. g. because modules are split into multiple css bundles.
I would recommend to not rely on CSS order between multiple files in general.

/cc @taylorsperry @muratsu

@valerybugakov valerybugakov added frontend-platform Issues related to our frontend platform, owned collectively by our frontend crew. css-order-in-production labels Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
css-order-in-production frontend-platform Issues related to our frontend platform, owned collectively by our frontend crew.
Projects
No open projects
Status: No status
Development

No branches or pull requests

1 participant