Add is_reference relationships between synthetic case class symbols
#561
+497
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, doing "Find references" on a synthetic case class symbol
(for example, named parameter of a `copy` method) then it only showed
usages of that symbol and the non-synthetic symbol (for example, the
case class field that matches the `copy` parameter). It didn't
return usages of other synthetic symbols that also relate to the case
class field (for example, the `apply` parameter).
This PR fixes the issue by adding `is_reference` relationships between
all synthetic symbols that relate to the same non-synthetic symbol.
Previously, it only ran `src code-intel upload` on git tags and master branch.
Needed to use `Nullable` annotation
keynmol
reviewed
Apr 24, 2023
Comment on lines
-20
to
23
| distribution: 'temurin' | ||
| distribution: "temurin" | ||
| java-version: 8 | ||
| cache: 'sbt' | ||
| cache: "sbt" | ||
|
|
There was a problem hiding this comment.
Rest of the changes aside, let's bikeshed about this for a few days.
There was a problem hiding this comment.
I have format on save enabled in VS Code and 🤷🏻 Worth adding a CI check to format the YAML files with prettier
keynmol
reviewed
Apr 24, 2023
| // ________ synthetic_definition semanticdb maven . . minimized/Issue396#productElement(). | ||
| // documentation ```scala\ndef productElement(x$1: Int): Any\n``` | ||
| // relationship is_definition semanticdb maven . . minimized/Issue396# | ||
| // relationship is_reference semanticdb maven . . minimized/Issue396.apply(). |
There was a problem hiding this comment.
Lifting from slack: both @olafurpg and I agree that productElement* family of methods shouldn't be referencing apply
copy is fine
default constructor is fine-ish (even though it's the other way around?)
keynmol
approved these changes
Apr 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, doing "Find references" on a synthetic case class symbol (for example, named parameter of a
copymethod) then it only showed usages of that symbol and the non-synthetic symbol (for example, thecase class field that matches the
copyparameter). It didn'treturn usages of other synthetic symbols that also relate to the case class field (for example, the
applyparameter).This PR fixes the issue by adding
is_referencerelationships between all synthetic symbols that relate to the same non-synthetic symbol.Test plan
See updated snapshots.