fix: typo in args #527
Merged
fix: typo in args #527
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Soooo, this was my mistake. I was curious why this wasn't working as expected and it's because we're checking `args` here instead of `arg`. Yay type safety.
Strum355
approved these changes
Jan 3, 2023
|
A release containing this fix would be very nice. Thanks! |
|
release v0.8.10 with this fix, docker image is already release, maven artifact takes a bit more time to propagate |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Soooo, this was my mistake. I was curious why this wasn't working as expected and it's because we're checking
argshere instead ofarg. Yay type safety.Test plan
Everything should test the same as before.