Skip to content

Use a better Java package name for generated Protobuf classes #458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 9, 2022
Merged

Use a better Java package name for generated Protobuf classes #458

merged 1 commit into from
Jun 9, 2022
+5 −2

Conversation

olafurpg
Copy link
Member

@olafurpg olafurpg commented Jun 9, 2022

Test plan

See the CI go green.

@olafurpg olafurpg requested a review from varungandhi-src June 9, 2022 15:49
olafurpg
olafurpg commented Jun 9, 2022
View reviewed changes
Copy link
Member Author

@olafurpg olafurpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may seem problematic that this repo has a modified copy of the original scip.proto but it's not really an issue IMO. We can fix more stuff later but right I just want to stop generating code to the lib.codeintel.scip package.

@olafurpg olafurpg enabled auto-merge June 9, 2022 15:54
@olafurpg olafurpg force-pushed the olafurpg/scip-package branch from 0365985 to e14f629 Compare June 9, 2022 16:18
@olafurpg olafurpg merged commit f26f08b into main Jun 9, 2022
@varungandhi-src varungandhi-src deleted the olafurpg/scip-package branch June 10, 2022 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@varungandhi-src varungandhi-src

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@olafurpg @varungandhi-src