Fix bug when indexing Scala package repo #373
Merged
+10
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we tried to infer the Scala version from the name of the jar of the dependency that we were indexing. Now, we infer from the first jar on the classpath that matches the `2_VERSION` pattern. The old logic didn't work for the sbt package repo, which doesn't include the `_2.12` suffix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we tried to infer the Scala version from the name of the jar
of the dependency that we were indexing. Now, we infer from the first
jar on the classpath that matches the
2_VERSIONpattern. The old logicdidn't work for the sbt package repo, which doesn't include the
_2.12suffix.
Fixes #318