Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PRs with changes only within the .github dir don't get the changelog:repository label #4804

Closed
waiting-for-dev opened this issue Dec 22, 2022 · 1 comment 路 Fixed by #5122
Closed

PRs with changes only within the .github dir don't get the changelog:repository label #4804

waiting-for-dev opened this issue Dec 22, 2022 · 1 comment 路 Fixed by #5122
Assignees
@waiting-for-dev
Labels
type:bug Error, flaw or fault

Comments

@waiting-for-dev
Copy link
Contributor

No description provided.

@waiting-for-dev waiting-for-dev added the type:bug Error, flaw or fault label Dec 22, 2022
@waiting-for-dev waiting-for-dev self-assigned this Dec 22, 2022
@waiting-for-dev
Copy link
Contributor Author

This, in fact, affects changes to any hidden directory. See actions/labeler#135 for the reported upstream issue. There's an open PR fixing it: actions/labeler#316.

Let's wait and see if that's fixed upstream. In our case, we have the Ensure Changelog Label workflow, which will catch most of the situations where we can be affected and it'll prompt us to add the label manually.

waiting-for-dev added a commit to nebulab/solidus that referenced this issue Jun 6, 2023
@waiting-for-dev
Fix changelog tracking for dot files
7e439e2 
After new release of the labeler action, changes to dot files are now
tracked.

This is available since v4.1. As we're tracking v4, it's going to be
automatically picked up and we can make use of the new option.

References actions/labeler#316

Fixes solidusio#4804
@waiting-for-dev waiting-for-dev mentioned this issue Jun 6, 2023
Merged
3 tasks
waiting-for-dev added a commit to nebulab/solidus that referenced this issue Jun 6, 2023
@waiting-for-dev
Fix changelog tracking for dot files
edfc321 
References actions/labeler#316

Fixes solidusio#4804
github-actions bot pushed a commit that referenced this issue Jun 6, 2023
@waiting-for-dev
Fix changelog tracking for dot files
8ad2211 
References actions/labeler#316

Fixes #4804

(cherry picked from commit edfc321)
github-actions bot pushed a commit that referenced this issue Jun 6, 2023
@waiting-for-dev
Fix changelog tracking for dot files
8640773 
References actions/labeler#316

Fixes #4804

(cherry picked from commit edfc321)
github-actions bot pushed a commit that referenced this issue Jun 6, 2023
@waiting-for-dev
Fix changelog tracking for dot files
9cc1381 
References actions/labeler#316

Fixes #4804

(cherry picked from commit edfc321)
github-actions bot pushed a commit that referenced this issue Jun 6, 2023
@waiting-for-dev
Fix changelog tracking for dot files
50b9bd6 
References actions/labeler#316

Fixes #4804

(cherry picked from commit edfc321)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@waiting-for-dev waiting-for-dev

Labels
type:bug Error, flaw or fault
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix changelog tracking for dot files nebulab/solidus
1 participant
@waiting-for-dev