Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README has reference to element which no longer exists. #388

Closed
klequis opened this issue Mar 1, 2024 · 0 comments
Closed

README has reference to element which no longer exists. #388

klequis opened this issue Mar 1, 2024 · 0 comments

Comments

@klequis
Copy link

klequis commented Mar 1, 2024

Describe the bug

A documentation issue, not a bug. I didn't see an option to open a doc issue here.

I think there is an error in the README file in the text below. If the word "element" here refers to the element prop of the Router component, that prop is not part of this version of the router.


Configure Your Routes
Solid Router allows you to configure your routes using JSX:

Add each route to a using the Route component, specifying a path and an element or component to render when the user navigates to that path.
---refers

Your Example Website or App

https://github.com/solidjs/solid-router/blob/main/README.md

Steps to Reproduce the Bug or Issue

README.md in this repository

Expected behavior

change

Add each route to a using the Route component, specifying a path and an element or component to render when the user navigates to that path.

to

Add each route to a using the Route component, specifying a path and a component to render when the user navigates to that path.

Screenshots or Videos

No response

Platform

Does not apply

Additional context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant