Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actually run CI on the right versions of Node #2499

Merged

Conversation

steveluscher
Copy link
Collaborator

This broke in #2273.

Copy link

changeset-bot bot commented Apr 16, 2024

⚠️ No Changeset found

Latest commit: 566436a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Collaborator Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @steveluscher and the rest of your teammates on Graphite Graphite

@steveluscher steveluscher force-pushed the 04-16-actually_run_ci_on_the_right_versions_of_node branch 2 times, most recently from 6d76b41 to b12c57d Compare April 16, 2024 21:04
@steveluscher steveluscher force-pushed the 04-16-actually_run_ci_on_the_right_versions_of_node branch from b12c57d to 566436a Compare April 16, 2024 21:16
@steveluscher
Copy link
Collaborator Author

Something in our CI doesn't work on Node 20, right? I was surprised to see this turn green.

Copy link
Collaborator

@buffalojoec buffalojoec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

x-files

@buffalojoec
Copy link
Collaborator

Something in our CI doesn't work on Node 20, right? I was surprised to see this turn green.

What are you referencing?

@steveluscher
Copy link
Collaborator Author

steveluscher commented Apr 17, 2024

I don't know. I have a faint recollection of someone hardcoding that install to version 18 because of something CI related.

¯\_(ツ)_/¯

@steveluscher steveluscher merged commit 96a4894 into master Apr 17, 2024
8 checks passed
@steveluscher steveluscher deleted the 04-16-actually_run_ci_on_the_right_versions_of_node branch April 17, 2024 00:45
Copy link
Contributor

🎉 This PR is included in version 1.91.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

@steveluscher
Copy link
Collaborator Author

Oh, LOL. #1786

Copy link
Contributor

github-actions bot commented May 1, 2024

Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants