This repository was archived by the owner on Mar 11, 2025. It is now read-only.
Add rustdocs #39
Merged
Add rustdocs #39
+197
−134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CriesofCarrots
approved these changes
Jun 17, 2020
| cd "$(dirname "$0")/../token/js" | ||
|
|
||
| npm install | ||
| npm run build:program |
There was a problem hiding this comment.
I'm not crazy about building a 2nd time.
I think if we remove this from package.json:
we can remove this 2ndary build. Wdyt?
There was a problem hiding this comment.
We could remove the program stuff entirely from the npm flow and instead toss up a warning message if the program does not exist and force them to go through do.sh for al program building/updating, etc...
There was a problem hiding this comment.
I would prefer that. (I assumed since you didn't do that since last night, you found a reason to keep it)
There was a problem hiding this comment.
I'll do a follow-up pr for that, was focusing on just getting CI to work and sufficiently cover
There was a problem hiding this comment.
I'm also happy to do that, if you prefer
ilmoi
pushed a commit
to ilmoi/solana-program-library
that referenced
this pull request
Oct 4, 2021
Add a canonical null address
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instructioninto its own file