fix(iOS,Fabric): fix MUTATION_PARENT_TAG definition when using dynamic frameworks #2737
+5
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kligarski
pushed a commit
that referenced
this pull request
Mar 6, 2025
…c frameworks (#2737) ## Description It seems that '-' characters in import names are swapped for '_' when using dynamic frameworks, therefore we need to check not only for `React-RCTAppDelegate` but also for `React_RCTAppDelegate`. ## Test code and steps to reproduce Build with `USE_FRAMEWORKS=dynamic` now passes. ## Checklist - [ ] Ensured that CI passes (cherry picked from commit e3eca55)
1 task
kligarski
added a commit
that referenced
this pull request
Mar 7, 2025
## Description Adding support for `react-native@0.78.0`. ## Changes - adjusted example apps (Android, iOS) on both architectures (Paper, Fabric) with changes from upgrade helper, - added additional fixes (android, ios, cpp) from 4.x (#2626), - updated dependencies, gradle of the library: - uncommented `syncArchs` task, because updating `react-native` version of the library fixed the problem with codegen, - fixed issue connected with Gesture Handler: - #2618, - updated TVOS example app (from 0.74.1) to match example app from 4.x and Android, iOS apps, - fixed a bug with `replaceNavigationBarViewsWithSnapshotOfSubview` method by adding a nil check: - adapted from #2485, - restoring backward compatibility: - #2730, - #2737. ## Test code and steps to reproduce CI ## Checklist - [ ] Ensured that CI passes --------- Co-authored-by: Kacper Kafara <kacper.kafara@swmansion.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It seems that '-' characters in import names are swapped for '_' when using dynamic frameworks,
therefore we need to check not only for
React-RCTAppDelegatebut also forReact_RCTAppDelegate.Test code and steps to reproduce
Build with
USE_FRAMEWORKS=dynamicnow passes.Checklist