Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: detect fabric with RN$Bridgeless #2722

Merged
merged 1 commit into from
Feb 20, 2025
Merged

Conversation

tjzel
Copy link
Contributor

@tjzel tjzel commented Feb 20, 2025

Description

Since 0.74 RN$Bridgeless is always defined in the global object and bridgeless mode isn't supported anymore. Therefore checking RN$Bridgeless for Fabric is safer than depending on _IS_FABRIC variable which we intend to remove in the future. RN$Bridgeless is added to global much faster than _IS_FABRIC.

See software-mansion/react-native-reanimated#7043

Changes

👍

Screenshots / GIFs

:shipit:

Test code and steps to reproduce

🚀

Checklist

Sorry, something went wrong.

Copy link
Member

@kkafar kkafar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

The CI errors are unrelated.

@kkafar kkafar merged commit 8bc0cc2 into main Feb 20, 2025
1 of 3 checks passed
@kkafar kkafar deleted the @tjzel/detect-fabric branch February 20, 2025 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants