feat(plugin): multiple worklet referencing #6904
Merged
+125
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjzel
commented
Jan 20, 2025
bartlomiejbloniarz
approved these changes
Feb 7, 2025
tjzel
added a commit
that referenced
this pull request
Feb 17, 2025
Some time ago I added a feature of worklet referencing to the Plugin,
but this was limited to only a single reference:
```ts
function foo(){
// UI stuff
};
runOnUI(foo)(); // ok, `foo` will get workletized
function bar(){
// UI stuff
};
const foobar = bar;
runOnUI(foobar); // error, foobar didn't get workletized
```
This PR allows for any amount of references in the reference chain.
Simultaneously I discovered that Gesture Handler callbacks didn't
benefit from worklet referencing, i.e. the following code would be
invalid:
```ts
function foo(){
// do something
}
const pan = Gesture.Pan().onActive(foo) // `foo` wouldn't be workletized
```
This PR adds this QoL feat for Gesture Handler callbacks.
I added new unit tests for these cases.
tjzel
added a commit
that referenced
this pull request
Feb 18, 2025
Some time ago I added a feature of worklet referencing to the Plugin,
but this was limited to only a single reference:
```ts
function foo(){
// UI stuff
};
runOnUI(foo)(); // ok, `foo` will get workletized
function bar(){
// UI stuff
};
const foobar = bar;
runOnUI(foobar); // error, foobar didn't get workletized
```
This PR allows for any amount of references in the reference chain.
Simultaneously I discovered that Gesture Handler callbacks didn't
benefit from worklet referencing, i.e. the following code would be
invalid:
```ts
function foo(){
// do something
}
const pan = Gesture.Pan().onActive(foo) // `foo` wouldn't be workletized
```
This PR adds this QoL feat for Gesture Handler callbacks.
I added new unit tests for these cases.
tjzel
added a commit
that referenced
this pull request
Feb 18, 2025
Some time ago I added a feature of worklet referencing to the Plugin,
but this was limited to only a single reference:
```ts
function foo(){
// UI stuff
};
runOnUI(foo)(); // ok, `foo` will get workletized
function bar(){
// UI stuff
};
const foobar = bar;
runOnUI(foobar); // error, foobar didn't get workletized
```
This PR allows for any amount of references in the reference chain.
Simultaneously I discovered that Gesture Handler callbacks didn't
benefit from worklet referencing, i.e. the following code would be
invalid:
```ts
function foo(){
// do something
}
const pan = Gesture.Pan().onActive(foo) // `foo` wouldn't be workletized
```
This PR adds this QoL feat for Gesture Handler callbacks.
I added new unit tests for these cases.
patrycjakalinska
pushed a commit
that referenced
this pull request
Mar 12, 2025
Some time ago I added a feature of worklet referencing to the Plugin,
but this was limited to only a single reference:
```ts
function foo(){
// UI stuff
};
runOnUI(foo)(); // ok, `foo` will get workletized
function bar(){
// UI stuff
};
const foobar = bar;
runOnUI(foobar); // error, foobar didn't get workletized
```
This PR allows for any amount of references in the reference chain.
Simultaneously I discovered that Gesture Handler callbacks didn't
benefit from worklet referencing, i.e. the following code would be
invalid:
```ts
function foo(){
// do something
}
const pan = Gesture.Pan().onActive(foo) // `foo` wouldn't be workletized
```
This PR adds this QoL feat for Gesture Handler callbacks.
I added new unit tests for these cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Some time ago I added a feature of worklet referencing to the Plugin, but this was limited to only a single reference:
This PR allows for any amount of references in the reference chain. Simultaneously I discovered that Gesture Handler callbacks didn't benefit from worklet referencing, i.e. the following code would be invalid:
This PR adds this QoL feat for Gesture Handler callbacks.
Test plan
I added new unit tests for these cases.