Move headers to apple directory
#6612
Merged
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @tomekzaw! ps. fking headers are so annoying to work with |
bartlomiejbloniarz
approved these changes
Oct 18, 2024
|
@efstathiosntonas Just FYI, today later on I will also submit another PR that should fix the headers when linking statically. This is just a pre-requirement for the workaround and I really wanted to do it in a separate PR. |
tomekzaw
added a commit
that referenced
this pull request
Oct 21, 2024
<!-- Thanks for submitting a pull request! We appreciate you spending the time to work on these changes. Please follow the template so that the reviewers can easily understand what the code changes affect. --> This PR moves iOS/macOS/tvOS headers from `apple/reanimated/` to yet another `apple` subdirectory so that the file tree reflects the paths in `#import <...>`. After this change, `apple/reanimated` can be added to `HEADER_SEARCH_PATHS` and imports like `reanimated/sensor/ReanimatedSensor.h` will work properly. <!-- Provide a minimal but complete code snippet that can be used to test out this change along with instructions how to run it and a description of the expected behavior. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR moves iOS/macOS/tvOS headers from
apple/reanimated/to yet anotherapplesubdirectory so that the file tree reflects the paths in#import <...>.After this change,
apple/reanimatedcan be added toHEADER_SEARCH_PATHSand imports likereanimated/sensor/ReanimatedSensor.hwill work properly.Test plan