current version does not match any files issue, previous version is okay

[qwerttvv]

The current version of https://github.com/softprops/action-gh-release/tree/20e085ccc73308c2c8e43ab8da4f8d7ecbb94d4e reports an error and then exits

Error: ⚠️ Pattern 'bin/ packages/x86_64/packages_ci/*ipk' does not match any files.

Instead of uploading the rest of the matched files, it just exits.

The previous version https://github.com/softprops/action-gh-release/tree/975c1b265e11dd76618af1c374e7981f9a6ff44a would skip the non-existing files and folders and continue to upload the matching files

🤔 Pattern 'bin/packages/x86_64/packages_ci/*ipk' does not match any files.
👩‍🏭 Creating new GitHub release for tag 2024.03.09-03.43_sm-x86_64...
⬆️ Uploading sm-x86_64-static.zip...
⬆️ Uploading sm-x86_64.zip...

yml looks like this

files: |
sm*.zip
bin/packages/${{ matrix.arch }}/packages_ci/*ipk

[softprops]

I suspect this is a new behavior introduced with #384 which I believe intended to surface mismatches patterns less quietly

I believe prior to that users had to opt into failing on mismatched patterns

action-gh-release/src/main.ts

Line 30 in 20e085c

if (patterns.length > 0 && config.input_fail_on_unmatched_files) {

If I’m reading the message above correctly it sounds like there were some files previously matched and some unmatched. I think the right thing to do is to make the previous change opt in so existing usages are impacted.

I’ll try to get that fix in this weekend.

[qwerttvv]

I suspect this is a new behavior introduced with #384 which I believe intended to surface mismatches patterns less quietly

I believe prior to that users had to opt into failing on mismatched patterns

action-gh-release/src/main.ts

Line 30 in 20e085c

if (patterns.length > 0 && config.input_fail_on_unmatched_files) {

If I’m reading the message above correctly it sounds like there were some files previously matched and some unmatched. I think the right thing to do is to make the previous change opt in so existing usages are impacted.

I’ll try to get that fix in this weekend.

Thanks a lot!

I'll keep using master to help with testing, or if you have another branch enabled on your end, let me know and I can help with testing ：）

[softprops]

@qwerttvv if you get a chance to check I've made that change in behavior opt in an updated the v2 tag to include those changes

[qwerttvv]

@qwerttvv if you get a chance to check I've made that change in behavior opt in an updated the v2 tag to include those changes

Thanks, just tested it and that problem is solved, thanks again