Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade deps to support oci images #4552

Merged
merged 1 commit into from
Apr 12, 2023
Merged

feat: upgrade deps to support oci images #4552

merged 1 commit into from
Apr 12, 2023

Conversation

kat1906
Copy link
Contributor

@kat1906 kat1906 commented Apr 11, 2023

What does this PR do?

Upgrade snyk-docker-plugin and @snyk/docker-registry-v2-client to support oci images.

How should this be manually tested?

monitor or test an OCI image

What are the relevant tickets?

https://snyk.zendesk.com/agent/tickets/45896
https://snyk.zendesk.com/agent/tickets/42839

@kat1906 kat1906 requested a review from a team as a code owner April 11, 2023 14:32
Copy link
Contributor

@PeterSchafer PeterSchafer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: Is there a chance that we can add acceptance tests for the new functionality to avoid regression in the future?

@kat1906 kat1906 merged commit 3b256e5 into master Apr 12, 2023
5 checks passed
@kat1906 kat1906 deleted the feat/support_oci branch April 12, 2023 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants