Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support severity threshold (unmanaged) #4216

Merged
merged 1 commit into from Nov 28, 2022
Merged

feat: support severity threshold (unmanaged) #4216

merged 1 commit into from Nov 28, 2022

Conversation

dekelund
Copy link
Contributor

@dekelund dekelund commented Nov 18, 2022 •
edited

What does this PR do?

Adds support to filter issues/vulnerabilities based on a severity threshold.

Where should the reviewer start?

How should this be manually tested?

  1. Change directory to a folder with unmanaged deps
  2. Use snyk test --unmanaged to verify that you have both "medium" and "high" severity-issues
  3. Test with an organization with unmanaged-deps enabled and run following command: snyk test --unmanaged --severity-threshold=high
  4. Verify that medium and lower was filtered out, and that "high" and "critical" remains

Screenshots

image

@github-actions
Copy link
Contributor

github-actions bot commented Nov 18, 2022 •
edited

Warnings
⚠️

You've modified files in src/ directory, but haven't updated anything in test folder. Is there something that could be tested?

Generated by 🚫 dangerJS against cc329fd

@dekelund dekelund force-pushed the feat/unmanaged-deps-severity-threshold branch from 5054c8d to 99b8b65 Compare November 28, 2022 09:33
@dekelund dekelund changed the title feat: support sev.threshold for unm.-deps feat: support severity threshold (unmanaged) Nov 28, 2022
@dekelund dekelund marked this pull request as ready for review November 28, 2022 13:25
@dekelund dekelund requested review from a team as code owners November 28, 2022 13:25
@dekelund dekelund force-pushed the feat/unmanaged-deps-severity-threshold branch from 99b8b65 to cc329fd Compare November 28, 2022 13:32
@dekelund dekelund merged commit c028b50 into master Nov 28, 2022
@dekelund dekelund deleted the feat/unmanaged-deps-severity-threshold branch November 28, 2022 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielroymoore danielroymoore danielroymoore approved these changes

@jk05 jk05 Awaiting requested review from jk05 jk05 was automatically assigned from snyk/snyk-open-source

@tonidevine1 tonidevine1 Awaiting requested review from tonidevine1 tonidevine1 was automatically assigned from snyk/snyk-open-source

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@dekelund @danielroymoore