Skip to content

Commit 6d183fb

Browse files
j-luongj-luong
committedNov 13, 2024··
fix: stop sending CLI args in analytics
·
v1.1296.0v1.1295.0
1 parent e5e0845 commit 6d183fb

File tree

6 files changed

+43
-44
lines changed

6 files changed

+43
-44
lines changed
 

‎CONTRIBUTING.md

+3-2
Original file line numberDiff line numberDiff line change
@@ -349,10 +349,11 @@ After the `release-npm` job successfully completes, an automated process generat
349349

350350
## Upgrading the go-application-framework
351351

352-
If you have made changes to the `go-application-framework`, you can run `python3 scripts/upgrade-go-application-framework.py`. This will;
352+
If you have made changes to the `go-application-framework`, you can run `go run ./scripts/upgrade-snyk-go-dependencies.go -name=go-application-framework`. This will;
353353

354-
- Fetch the most recent commit from main of the framework
354+
- Fetch the most recent commit from the `main` branch of the framework
355355
- Go get that version of the framework
356+
- Run `go mod tidy` to ensure the `go.mod` file matches the source code in the module
356357

357358
You can then raise a pr with the relevant changes.
358359

‎cliv2/go.mod

+10-10
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,8 @@ require (
1616
github.com/snyk/cli-extension-iac-rules v0.0.0-20241008152401-24c8cf03a1a3
1717
github.com/snyk/cli-extension-sbom v0.0.0-20241016065306-0df2be5b3b8f
1818
github.com/snyk/container-cli v0.0.0-20240821111304-7ca1c415a5d7
19-
github.com/snyk/error-catalog-golang-public v0.0.0-20240809094525-c48d19c27edb
20-
github.com/snyk/go-application-framework v0.0.0-20241105130756-9d4de29b4af4
19+
github.com/snyk/error-catalog-golang-public v0.0.0-20241030160523-0aa643bb7069
20+
github.com/snyk/go-application-framework v0.0.0-20241113091434-5316070f13f9
2121
github.com/snyk/go-httpauth v0.0.0-20240307114523-1f5ea3f55c65
2222
github.com/snyk/snyk-iac-capture v0.6.5
2323
github.com/snyk/snyk-ls v0.0.0-20241111125011-8d32cec04e8b
@@ -195,17 +195,17 @@ require (
195195
go.opentelemetry.io/otel/metric v1.29.0 // indirect
196196
go.opentelemetry.io/otel/trace v1.29.0 // indirect
197197
go.uber.org/multierr v1.11.0 // indirect
198-
golang.org/x/crypto v0.28.0 // indirect
198+
golang.org/x/crypto v0.29.0 // indirect
199199
golang.org/x/exp v0.0.0-20240808152545-0cdaa3abc0fa // indirect
200-
golang.org/x/mod v0.21.0 // indirect
201-
golang.org/x/net v0.30.0 // indirect
200+
golang.org/x/mod v0.22.0 // indirect
201+
golang.org/x/net v0.31.0 // indirect
202202
golang.org/x/oauth2 v0.22.0 // indirect
203-
golang.org/x/sync v0.8.0 // indirect
204-
golang.org/x/sys v0.26.0 // indirect
205-
golang.org/x/term v0.25.0 // indirect
206-
golang.org/x/text v0.19.0 // indirect
203+
golang.org/x/sync v0.9.0 // indirect
204+
golang.org/x/sys v0.27.0 // indirect
205+
golang.org/x/term v0.26.0 // indirect
206+
golang.org/x/text v0.20.0 // indirect
207207
golang.org/x/time v0.6.0 // indirect
208-
golang.org/x/tools v0.26.0 // indirect
208+
golang.org/x/tools v0.27.0 // indirect
209209
google.golang.org/api v0.195.0 // indirect
210210
google.golang.org/genproto v0.0.0-20240827150818-7e3bb234dfed // indirect
211211
google.golang.org/genproto/googleapis/api v0.0.0-20240827150818-7e3bb234dfed // indirect

‎cliv2/go.sum

+20-20
Original file line numberDiff line numberDiff line change
@@ -760,10 +760,10 @@ github.com/snyk/code-client-go v1.10.0 h1:t/hBINxj4lKvoo681uGhxHBpMued/j68p2sHbB
760760
github.com/snyk/code-client-go v1.10.0/go.mod h1:orU911flV1kJQOlxxx0InUQkAfpBrcERsb2olfnlI8s=
761761
github.com/snyk/container-cli v0.0.0-20240821111304-7ca1c415a5d7 h1:Zn5BcV76oFAbJm5tDygU945lvoZ3yY8FoRFDC3YpwF8=
762762
github.com/snyk/container-cli v0.0.0-20240821111304-7ca1c415a5d7/go.mod h1:38w+dcAQp9eG3P5t2eNS9eG0reut10AeJjLv5lJ5lpM=
763-
github.com/snyk/error-catalog-golang-public v0.0.0-20240809094525-c48d19c27edb h1:w9tJhpTFxWqAhLeraGsMExDjGK9x5Dwj1NRFwb+t+QE=
764-
github.com/snyk/error-catalog-golang-public v0.0.0-20240809094525-c48d19c27edb/go.mod h1:Ytttq7Pw4vOCu9NtRQaOeDU2dhBYUyNBe6kX4+nIIQ4=
765-
github.com/snyk/go-application-framework v0.0.0-20241105130756-9d4de29b4af4 h1:lwfk5tos7680HuWbdoENzqYZIrs5Y5x3CC1Ow80riKQ=
766-
github.com/snyk/go-application-framework v0.0.0-20241105130756-9d4de29b4af4/go.mod h1:5aMJH42nmeZgPRXvN5fdAZVoutATPnY9yTb68Iz7zYk=
763+
github.com/snyk/error-catalog-golang-public v0.0.0-20241030160523-0aa643bb7069 h1:Oj/BJAEMEuBjTAQ72UYB4tR0IZKOB2ZtdDnAnJDL1BM=
764+
github.com/snyk/error-catalog-golang-public v0.0.0-20241030160523-0aa643bb7069/go.mod h1:Ytttq7Pw4vOCu9NtRQaOeDU2dhBYUyNBe6kX4+nIIQ4=
765+
github.com/snyk/go-application-framework v0.0.0-20241113091434-5316070f13f9 h1:U6g5lPxysC5dJPSXlfHOP1w9cvi1m4bRmmU14Tp7Bjs=
766+
github.com/snyk/go-application-framework v0.0.0-20241113091434-5316070f13f9/go.mod h1:xFKQOJ3MYYb+aYuHweczYQEa87XMBv6NnKAPwl08cVU=
767767
github.com/snyk/go-httpauth v0.0.0-20240307114523-1f5ea3f55c65 h1:CEQuYv0Go6MEyRCD3YjLYM2u3Oxkx8GpCpFBd4rUTUk=
768768
github.com/snyk/go-httpauth v0.0.0-20240307114523-1f5ea3f55c65/go.mod h1:88KbbvGYlmLgee4OcQ19yr0bNpXpOr2kciOthaSzCAg=
769769
github.com/snyk/policy-engine v0.31.3 h1:FepCg6QN/X8uvxYjF+WwB2aiBPJB+NENDgKQeI/FwLg=
@@ -895,8 +895,8 @@ golang.org/x/crypto v0.0.0-20220622213112-05595931fe9d/go.mod h1:IxCIyHEi3zRg3s0
895895
golang.org/x/crypto v0.3.1-0.20221117191849-2c476679df9a/go.mod h1:hebNnKkNXi2UzZN1eVRvBB7co0a+JxK6XbPiWVs/3J4=
896896
golang.org/x/crypto v0.6.0/go.mod h1:OFC/31mSvZgRz0V1QTNCzfAI1aIRzbiufJtkMIlEp58=
897897
golang.org/x/crypto v0.7.0/go.mod h1:pYwdfH91IfpZVANVyUOhSIPZaFoJGxTFbZhFTx+dXZU=
898-
golang.org/x/crypto v0.28.0 h1:GBDwsMXVQi34v5CCYUm2jkJvu4cbtru2U4TN2PSyQnw=
899-
golang.org/x/crypto v0.28.0/go.mod h1:rmgy+3RHxRZMyY0jjAJShp2zgEdOqj2AO7U0pYmeQ7U=
898+
golang.org/x/crypto v0.29.0 h1:L5SG1JTTXupVV3n6sUqMTeWbjAyfPwoda2DLX8J8FrQ=
899+
golang.org/x/crypto v0.29.0/go.mod h1:+F4F4N5hv6v38hfeYwTdx20oUvLLc+QfrE9Ax9HtgRg=
900900
golang.org/x/exp v0.0.0-20190121172915-509febef88a4/go.mod h1:CJ0aWSM057203Lf6IL+f9T1iT9GByDxfZKAQTCR3kQA=
901901
golang.org/x/exp v0.0.0-20190306152737-a1d7652674e8/go.mod h1:CJ0aWSM057203Lf6IL+f9T1iT9GByDxfZKAQTCR3kQA=
902902
golang.org/x/exp v0.0.0-20190510132918-efd6b22b2522/go.mod h1:ZjyILWgesfNpC6sMxTJOJm9Kp84zZh5NQWvqDGG3Qr8=
@@ -937,8 +937,8 @@ golang.org/x/mod v0.4.1/go.mod h1:s0Qsj1ACt9ePp/hMypM3fl4fZqREWJwdYDEqhRiZZUA=
937937
golang.org/x/mod v0.4.2/go.mod h1:s0Qsj1ACt9ePp/hMypM3fl4fZqREWJwdYDEqhRiZZUA=
938938
golang.org/x/mod v0.6.0-dev.0.20220419223038-86c51ed26bb4/go.mod h1:jJ57K6gSWd91VN4djpZkiMVwK6gcyfeH4XE8wZrZaV4=
939939
golang.org/x/mod v0.8.0/go.mod h1:iBbtSCu2XBx23ZKBPSOrRkjjQPZFPuis4dIYUhu/chs=
940-
golang.org/x/mod v0.21.0 h1:vvrHzRwRfVKSiLrG+d4FMl/Qi4ukBCE6kZlTUkDYRT0=
941-
golang.org/x/mod v0.21.0/go.mod h1:6SkKJ3Xj0I0BrPOZoBy3bdMptDDU9oJrpohJ3eWZ1fY=
940+
golang.org/x/mod v0.22.0 h1:D4nJWe9zXqHOmWqj4VMOJhvzj7bEZg4wEYa759z1pH4=
941+
golang.org/x/mod v0.22.0/go.mod h1:6SkKJ3Xj0I0BrPOZoBy3bdMptDDU9oJrpohJ3eWZ1fY=
942942
golang.org/x/net v0.0.0-20180724234803-3673e40ba225/go.mod h1:mL1N/T3taQHkDXs73rZJwtUhF3w3ftmwwsq0BUmARs4=
943943
golang.org/x/net v0.0.0-20180811021610-c39426892332/go.mod h1:mL1N/T3taQHkDXs73rZJwtUhF3w3ftmwwsq0BUmARs4=
944944
golang.org/x/net v0.0.0-20180826012351-8a410e7b638d/go.mod h1:mL1N/T3taQHkDXs73rZJwtUhF3w3ftmwwsq0BUmARs4=
@@ -993,8 +993,8 @@ golang.org/x/net v0.2.0/go.mod h1:KqCZLdyyvdV855qA2rE3GC2aiw5xGR5TEjj8smXukLY=
993993
golang.org/x/net v0.6.0/go.mod h1:2Tu9+aMcznHK/AK1HMvgo6xiTLG5rD5rZLDS+rp2Bjs=
994994
golang.org/x/net v0.7.0/go.mod h1:2Tu9+aMcznHK/AK1HMvgo6xiTLG5rD5rZLDS+rp2Bjs=
995995
golang.org/x/net v0.8.0/go.mod h1:QVkue5JL9kW//ek3r6jTKnTFis1tRmNAW2P1shuFdJc=
996-
golang.org/x/net v0.30.0 h1:AcW1SDZMkb8IpzCdQUaIq2sP4sZ4zw+55h6ynffypl4=
997-
golang.org/x/net v0.30.0/go.mod h1:2wGyMJ5iFasEhkwi13ChkO/t1ECNC4X4eBKkVFyYFlU=
996+
golang.org/x/net v0.31.0 h1:68CPQngjLL0r2AlUKiSxtQFKvzRVbnzLwMUn5SzcLHo=
997+
golang.org/x/net v0.31.0/go.mod h1:P4fl1q7dY2hnZFxEk4pPSkDHF+QqjitcnDjUQyMM+pM=
998998
golang.org/x/oauth2 v0.0.0-20180821212333-d2e6202438be/go.mod h1:N/0e6XlmueqKjAGxoOufVs8QHGRruUQn6yWY3a++T0U=
999999
golang.org/x/oauth2 v0.0.0-20190226205417-e64efc72b421/go.mod h1:gOpvHmFTYa4IltrdGE7lF6nIHvwfUNPOp7c8zoXwtLw=
10001000
golang.org/x/oauth2 v0.0.0-20190604053449-0f29369cfe45/go.mod h1:gOpvHmFTYa4IltrdGE7lF6nIHvwfUNPOp7c8zoXwtLw=
@@ -1037,8 +1037,8 @@ golang.org/x/sync v0.0.0-20220601150217-0de741cfad7f/go.mod h1:RxMgew5VJxzue5/jJ
10371037
golang.org/x/sync v0.0.0-20220722155255-886fb9371eb4/go.mod h1:RxMgew5VJxzue5/jJTE5uejpjVlOe/izrB70Jof72aM=
10381038
golang.org/x/sync v0.0.0-20220929204114-8fcdb60fdcc0/go.mod h1:RxMgew5VJxzue5/jJTE5uejpjVlOe/izrB70Jof72aM=
10391039
golang.org/x/sync v0.1.0/go.mod h1:RxMgew5VJxzue5/jJTE5uejpjVlOe/izrB70Jof72aM=
1040-
golang.org/x/sync v0.8.0 h1:3NFvSEYkUoMifnESzZl15y791HH1qU2xm6eCJU5ZPXQ=
1041-
golang.org/x/sync v0.8.0/go.mod h1:Czt+wKu1gCyEFDUtn0jG5QVvpJ6rzVqr5aXyt9drQfk=
1040+
golang.org/x/sync v0.9.0 h1:fEo0HyrW1GIgZdpbhCRO0PkJajUS5H9IFUztCgEo2jQ=
1041+
golang.org/x/sync v0.9.0/go.mod h1:Czt+wKu1gCyEFDUtn0jG5QVvpJ6rzVqr5aXyt9drQfk=
10421042
golang.org/x/sys v0.0.0-20180830151530-49385e6e1522/go.mod h1:STP8DvDyc/dI5b8T5hshtkjS+E42TnysNCUPdjciGhY=
10431043
golang.org/x/sys v0.0.0-20190215142949-d0b11bdaac8a/go.mod h1:STP8DvDyc/dI5b8T5hshtkjS+E42TnysNCUPdjciGhY=
10441044
golang.org/x/sys v0.0.0-20190312061237-fead79001313/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs=
@@ -1116,16 +1116,16 @@ golang.org/x/sys v0.3.0/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
11161116
golang.org/x/sys v0.5.0/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
11171117
golang.org/x/sys v0.6.0/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
11181118
golang.org/x/sys v0.12.0/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
1119-
golang.org/x/sys v0.26.0 h1:KHjCJyddX0LoSTb3J+vWpupP9p0oznkqVk/IfjymZbo=
1120-
golang.org/x/sys v0.26.0/go.mod h1:/VUhepiaJMQUp4+oa/7Zr1D23ma6VTLIYjOOTFZPUcA=
1119+
golang.org/x/sys v0.27.0 h1:wBqf8DvsY9Y/2P8gAfPDEYNuS30J4lPHJxXSb/nJZ+s=
1120+
golang.org/x/sys v0.27.0/go.mod h1:/VUhepiaJMQUp4+oa/7Zr1D23ma6VTLIYjOOTFZPUcA=
11211121
golang.org/x/term v0.0.0-20201126162022-7de9c90e9dd1/go.mod h1:bj7SfCRtBDWHUb9snDiAeCFNEtKQo2Wmx5Cou7ajbmo=
11221122
golang.org/x/term v0.0.0-20210927222741-03fcf44c2211/go.mod h1:jbD1KX2456YbFQfuXm/mYQcufACuNUgVhRMnK/tPxf8=
11231123
golang.org/x/term v0.1.0/go.mod h1:jbD1KX2456YbFQfuXm/mYQcufACuNUgVhRMnK/tPxf8=
11241124
golang.org/x/term v0.2.0/go.mod h1:TVmDHMZPmdnySmBfhjOoOdhjzdE1h4u1VwSiw2l1Nuc=
11251125
golang.org/x/term v0.5.0/go.mod h1:jMB1sMXY+tzblOD4FWmEbocvup2/aLOaQEp7JmGp78k=
11261126
golang.org/x/term v0.6.0/go.mod h1:m6U89DPEgQRMq3DNkDClhWw02AUbt2daBVO4cn4Hv9U=
1127-
golang.org/x/term v0.25.0 h1:WtHI/ltw4NvSUig5KARz9h521QvRC8RmF/cuYqifU24=
1128-
golang.org/x/term v0.25.0/go.mod h1:RPyXicDX+6vLxogjjRxjgD2TKtmAO6NZBsBRfrOLu7M=
1127+
golang.org/x/term v0.26.0 h1:WEQa6V3Gja/BhNxg540hBip/kkaYtRg3cxg4oXSw4AU=
1128+
golang.org/x/term v0.26.0/go.mod h1:Si5m1o57C5nBNQo5z1iq+XDijt21BDBDp2bK0QI8e3E=
11291129
golang.org/x/text v0.0.0-20170915032832-14c0d48ead0c/go.mod h1:NqM8EUOU14njkJ3fqMW+pc6Ldnwhi/IjpwHt7yyuwOQ=
11301130
golang.org/x/text v0.3.0/go.mod h1:NqM8EUOU14njkJ3fqMW+pc6Ldnwhi/IjpwHt7yyuwOQ=
11311131
golang.org/x/text v0.3.1-0.20180807135948-17ff2d5776d2/go.mod h1:NqM8EUOU14njkJ3fqMW+pc6Ldnwhi/IjpwHt7yyuwOQ=
@@ -1138,8 +1138,8 @@ golang.org/x/text v0.3.7/go.mod h1:u+2+/6zg+i71rQMx5EYifcz6MCKuco9NR6JIITiCfzQ=
11381138
golang.org/x/text v0.4.0/go.mod h1:mrYo+phRRbMaCq/xk9113O4dZlRixOauAjOtrjsXDZ8=
11391139
golang.org/x/text v0.7.0/go.mod h1:mrYo+phRRbMaCq/xk9113O4dZlRixOauAjOtrjsXDZ8=
11401140
golang.org/x/text v0.8.0/go.mod h1:e1OnstbJyHTd6l/uOt8jFFHp6TRDWZR/bV3emEE/zU8=
1141-
golang.org/x/text v0.19.0 h1:kTxAhCbGbxhK0IwgSKiMO5awPoDQ0RpfiVYBfK860YM=
1142-
golang.org/x/text v0.19.0/go.mod h1:BuEKDfySbSR4drPmRPG/7iBdf8hvFMuRexcpahXilzY=
1141+
golang.org/x/text v0.20.0 h1:gK/Kv2otX8gz+wn7Rmb3vT96ZwuoxnQlY+HlJVj7Qug=
1142+
golang.org/x/text v0.20.0/go.mod h1:D4IsuqiFMhST5bX19pQ9ikHC2GsaKyk/oF+pn3ducp4=
11431143
golang.org/x/time v0.0.0-20181108054448-85acf8d2951c/go.mod h1:tRJNPiyCQ0inRvYxbN9jk5I+vvW/OXSQhTDSoE431IQ=
11441144
golang.org/x/time v0.0.0-20190308202827-9d24e82272b4/go.mod h1:tRJNPiyCQ0inRvYxbN9jk5I+vvW/OXSQhTDSoE431IQ=
11451145
golang.org/x/time v0.0.0-20191024005414-555d28b269f0/go.mod h1:tRJNPiyCQ0inRvYxbN9jk5I+vvW/OXSQhTDSoE431IQ=
@@ -1198,8 +1198,8 @@ golang.org/x/tools v0.1.4/go.mod h1:o0xws9oXOQQZyjljx8fwUC0k7L1pTE6eaCbjGeHmOkk=
11981198
golang.org/x/tools v0.1.5/go.mod h1:o0xws9oXOQQZyjljx8fwUC0k7L1pTE6eaCbjGeHmOkk=
11991199
golang.org/x/tools v0.1.12/go.mod h1:hNGJHUnrk76NpqgfD5Aqm5Crs+Hm0VOH/i9J2+nxYbc=
12001200
golang.org/x/tools v0.6.0/go.mod h1:Xwgl3UAJ/d3gWutnCtw505GrjyAbvKui8lOU390QaIU=
1201-
golang.org/x/tools v0.26.0 h1:v/60pFQmzmT9ExmjDv2gGIfi3OqfKoEP6I5+umXlbnQ=
1202-
golang.org/x/tools v0.26.0/go.mod h1:TPVVj70c7JJ3WCazhD8OdXcZg/og+b9+tH/KxylGwH0=
1201+
golang.org/x/tools v0.27.0 h1:qEKojBykQkQ4EynWy4S8Weg69NumxKdn40Fce3uc/8o=
1202+
golang.org/x/tools v0.27.0/go.mod h1:sUi0ZgbwW9ZPAq26Ekut+weQPR5eIM6GQLQ1Yjm1H0Q=
12031203
golang.org/x/xerrors v0.0.0-20190717185122-a985d3407aa7/go.mod h1:I/5z698sn9Ka8TeJc9MKroUUfqBBauWjQqLJ2OPfmY0=
12041204
golang.org/x/xerrors v0.0.0-20191011141410-1b5146add898/go.mod h1:I/5z698sn9Ka8TeJc9MKroUUfqBBauWjQqLJ2OPfmY0=
12051205
golang.org/x/xerrors v0.0.0-20191204190536-9bdfabe68543/go.mod h1:I/5z698sn9Ka8TeJc9MKroUUfqBBauWjQqLJ2OPfmY0=

‎src/lib/analytics/index.ts

+4-1
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,6 @@ async function postAnalytics(
8484
...customData,
8585
...standardData,
8686
};
87-
debug('analytics', JSON.stringify(analyticsData, null, ' '));
8887

8988
const headers = {};
9089
if (someTokenExists()) {
@@ -99,6 +98,10 @@ async function postAnalytics(
9998
const queryString =
10099
Object.keys(queryStringParams).length > 0 ? queryStringParams : undefined;
101100

101+
// CLI-586 - do not send CLI args to analytics
102+
analyticsData.args = [];
103+
104+
debug('analytics', JSON.stringify(analyticsData, null, ' '));
102105
const res = await makeRequest({
103106
body: {
104107
data: analyticsData,

‎test/jest/acceptance/analytics.spec.ts

+5-5
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ describe('analytics module', () => {
6868
query: {},
6969
body: {
7070
data: {
71-
args: [{}],
71+
args: [],
7272
ci: expect.any(Boolean),
7373
command: 'test',
7474
metadata: {
@@ -142,7 +142,7 @@ describe('analytics module', () => {
142142
query: {},
143143
body: {
144144
data: {
145-
args: [{}],
145+
args: [],
146146
ci: expect.any(Boolean),
147147
command: 'test',
148148
metadata: {
@@ -220,7 +220,7 @@ describe('analytics module', () => {
220220
query: {},
221221
body: {
222222
data: {
223-
args: ['random-nonsense-command'],
223+
args: [],
224224
ci: expect.any(Boolean),
225225
command: 'bad-command',
226226
metadata: {
@@ -289,7 +289,7 @@ describe('analytics module', () => {
289289
query: {},
290290
body: {
291291
data: {
292-
args: [{}],
292+
args: [],
293293
ci: expect.any(Boolean),
294294
command: 'bad-command',
295295
metadata: {
@@ -365,7 +365,7 @@ describe('analytics module', () => {
365365
query: {},
366366
body: {
367367
data: {
368-
args: ['help', {}],
368+
args: [],
369369
ci: expect.any(Boolean),
370370
command: 'help',
371371
durationMs: expect.any(Number),

‎test/jest/unit/lib/analytics/index.spec.ts

+1-6
Original file line numberDiff line numberDiff line change
@@ -37,12 +37,7 @@ describe('analytics module', () => {
3737
}),
3838
});
3939

40-
expect(requestSpy.mock.calls[0][0].body.data).toHaveProperty('args', [
41-
{
42-
'tfc-endpoint': "I don't care who sees this",
43-
'tfc-token': 'REDACTED',
44-
},
45-
]);
40+
expect(requestSpy.mock.calls[0][0].body.data).toHaveProperty('args', []);
4641
});
4742

4843
it('ignores analytics request failures', async () => {

0 commit comments

Comments
 (0)
Please sign in to comment.