Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1157904 write and bindings structured types #1727

Merged

Conversation

sfc-gh-pmotacki
Copy link
Collaborator

@sfc-gh-pmotacki sfc-gh-pmotacki commented Apr 18, 2024

Overview

SNOW-1157904

Pre-review self checklist

  • PR branch is updated with all the changes from master branch
  • The code is correctly formatted (run mvn -P check-style validate)
  • New public API is not unnecessary exposed (run mvn verify and inspect target/japicmp/japicmp.html)
  • The pull request name is prefixed with SNOW-XXXX:

External contributors - please answer these questions before submitting a pull request. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes #NNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency or upgrading an existing one
    • I am adding new public/protected component not marked with @SnowflakeJdbcInternalApi (note that public/protected methods/fields in classes marked with this annotation are already internal)
  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

Sorry, something went wrong.

@sfc-gh-pmotacki sfc-gh-pmotacki changed the title Snow 1157904 write and bindings structured types SNOW-1157904 write and bindings structured types Apr 18, 2024
@sfc-gh-pmotacki sfc-gh-pmotacki force-pushed the SNOW-1157904-write-and-bindings-structured-types branch from 4cad801 to 3ddeb36 Compare April 18, 2024 03:08
@sfc-gh-pmotacki sfc-gh-pmotacki marked this pull request as ready for review April 18, 2024 11:48
@sfc-gh-pmotacki sfc-gh-pmotacki requested a review from a team as a code owner April 18, 2024 11:48
@sfc-gh-pmotacki sfc-gh-pmotacki force-pushed the SNOW-1157904-write-and-bindings-structured-types branch from cc5c403 to 0e05a6d Compare April 24, 2024 12:01

Verified

This commit was signed with the committer’s verified signature.
richardlau Richard Lau
SNOW-1312775 - nested structures - readArray, readList, readMap
@sfc-gh-pmotacki sfc-gh-pmotacki force-pushed the SNOW-1157904-write-and-bindings-structured-types branch from 0e05a6d to fc2ed23 Compare April 24, 2024 12:02
@sfc-gh-pmotacki sfc-gh-pmotacki merged commit 8dcd217 into master Apr 26, 2024
35 checks passed
@sfc-gh-pmotacki sfc-gh-pmotacki deleted the SNOW-1157904-write-and-bindings-structured-types branch April 26, 2024 17:16
@github-actions github-actions bot locked and limited conversation to collaborators Apr 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants