Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-937199 Use JDK 11 and 17 in Jenkins #1564

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

sfc-gh-pfus
Copy link
Contributor

@sfc-gh-pfus sfc-gh-pfus commented Nov 20, 2023

Overview

SNOW-937199 - include JDK 11 and 17 in Jenkins jobs.

@sfc-gh-pfus sfc-gh-pfus force-pushed the SNOW-937199-jenkins-images branch 27 times, most recently from 2b0df5e to 4a24089 Compare November 24, 2023 08:04
@sfc-gh-pfus sfc-gh-pfus marked this pull request as ready for review November 24, 2023 08:11
@sfc-gh-pfus sfc-gh-pfus requested a review from a team as a code owner November 24, 2023 08:11
Jenkinsfile Show resolved Hide resolved
Jenkinsfile Show resolved Hide resolved
Jenkinsfile Show resolved Hide resolved
Jenkinsfile Outdated Show resolved Hide resolved
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Collaborator

@sfc-gh-igarish sfc-gh-igarish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfc-gh-igarish
Copy link
Collaborator

Do we know how much time increase after adding all JDK here? If each PR it's taking too long than we can think of to do all JDK testing during release time only. what do you think? Previous time was 2 hrs 30 minutes as per my observation.

@sfc-gh-pfus
Copy link
Contributor Author

@sfc-gh-igarish All builds run in parallel. Actually the longest build is code coverage on Java 8 and total time spent on build is because of that. We can try to improve it, but it would be better to do it in a separate task.

@sfc-gh-pfus sfc-gh-pfus merged commit dcb74ed into master Nov 30, 2023
28 checks passed
@sfc-gh-pfus sfc-gh-pfus deleted the SNOW-937199-jenkins-images branch November 30, 2023 09:59
@github-actions github-actions bot locked and limited conversation to collaborators Nov 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants