Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-874337: move from current version of urllib (v2) #590

Closed
sfc-gh-dszmolka opened this issue Jul 22, 2023 · 6 comments
Closed

SNOW-874337: move from current version of urllib (v2) #590

sfc-gh-dszmolka opened this issue Jul 22, 2023 · 6 comments
Assignees
Labels
enhancement The issue is a request for improvement or a new feature status-fixed_awaiting_release The issue has been fixed, its PR merged, and now awaiting the next release cycle of the connector.

Comments

@sfc-gh-dszmolka
Copy link
Collaborator

sfc-gh-dszmolka commented Jul 22, 2023

Raising this issue to give a more transparent way to track the internal effort of addressing the current challenges around urllib v2.

Background:
There already a couple of issues of various severity, stemming from urllib v2 (2.40.0) and its direct/indirect dependencies, which urllib version is currently in use by the Snowflake Node.JS driver, some examples:

We cannot just take the urllib dependency and bump to the most recent (v3) versions, because urllib v3.0.0 introduced a breaking change as is't been rebased to undici and that version is incompatible with snowflake-sdk implementation today.

As urllib provides a core functionality to snowflake-sdk (sending HTTP requests to the Snowflake engine) , appropriate care needs to be taken in refactoring the solution.

This Issue is here to track the progress. Current aim is to implement and release the changes by end of Q3 2023

@sfc-gh-dszmolka sfc-gh-dszmolka added enhancement The issue is a request for improvement or a new feature status-in_progress Issue is worked on by the driver team labels Jul 22, 2023
@github-actions github-actions bot changed the title move from current version of urllib (v2) SNOW-874337: move from current version of urllib (v2) Jul 22, 2023
@StefanTobler
Copy link

Hey there, is there any target date for this fix?

@sfc-gh-dszmolka
Copy link
Collaborator Author

yes, apologies for missing it out from the original post. I now added it there, and adding it here too: latest target date is end of Q3 (October). Being a high priority item, we aim for a quicker implementation but that's the current timing.

@mootari
Copy link

mootari commented Aug 21, 2023

Are you planning to replace urllib with Node-native APIs?

@sfc-gh-dszmolka
Copy link
Collaborator Author

as far as I know, there might be multiple approaches on the table still. I'll keep this Issue updated with the details as they become available to the public.

@sfc-gh-dszmolka
Copy link
Collaborator Author

sfc-gh-dszmolka commented Sep 12, 2023

after all, as a result of a long consideration and multiple internal discussions, we decided to go with axios instead of urllib v3 to replace urllib v2, and the change has been merged with #623 .

It will be part of the next upcoming release towards end of September.

@sfc-gh-dszmolka sfc-gh-dszmolka added status-fixed_awaiting_release The issue has been fixed, its PR merged, and now awaiting the next release cycle of the connector. and removed status-in_progress Issue is worked on by the driver team labels Sep 12, 2023
@sfc-gh-dszmolka
Copy link
Collaborator Author

fix is now out with release 1.9.0 , available on npm as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement The issue is a request for improvement or a new feature status-fixed_awaiting_release The issue has been fixed, its PR merged, and now awaiting the next release cycle of the connector.
Projects
None yet
Development

No branches or pull requests

4 participants